Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs) Add support for module categories; remove cruft #330

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Conversation

brandones
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests, or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Improves some things about the API docs.

Also removes an old workspace function. It didn't do anything.

@github-actions
Copy link
Contributor

File size impact

Merging docs-api into master impact files as follow:

@openmrs/esm-devtools-app (-0.08%)
Files new size
packages/apps/esm-devtools-app/dist/217.js 322 kB (-276 B / -0.09%) ↘️
Unmodified (4) 25.2 kB (0 B / +0%) 👻
Total (5) 347 kB (-276 B / -0.08%) ↘️
@openmrs/esm-implementer-tools-app (-0.02%)
Files new size
packages/apps/esm-implementer-tools-app/dist/217.js 322 kB (-276 B / -0.09%) ↘️
Unmodified (16) 1.29 MB (0 B / +0%) 👻
Total (17) 1.61 MB (-276 B / -0.02%) ↘️
@openmrs/esm-login-app (-0.01%)
Files new size
packages/apps/esm-login-app/dist/217.js 322 kB (-276 B / -0.09%) ↘️
Unmodified (27) 1.61 MB (0 B / +0%) 👻
Total (28) 1.93 MB (-276 B / -0.01%) ↘️
@openmrs/esm-offline-tools-app (-0.01%)
Files new size
packages/apps/esm-offline-tools-app/dist/217.js 322 kB (-276 B / -0.09%) ↘️
Unmodified (25) 2.37 MB (0 B / +0%) 👻
Total (26) 2.69 MB (-276 B / -0.01%) ↘️
@openmrs/esm-primary-navigation-app (-0.01%)
Files new size
packages/apps/esm-primary-navigation-app/dist/217.js 322 kB (-276 B / -0.09%) ↘️
Unmodified (17) 1.74 MB (0 B / +0%) 👻
Total (18) 2.06 MB (-276 B / -0.01%) ↘️
@openmrs/esm-app-shell (-0.02%)
Files new size
packages/shell/esm-app-shell/dist/openmrs.js 1.33 MB (-322 B / -0.02%) ↘️
packages/shell/esm-app-shell/dist/service-worker.js 163 kB (0 B / +0%) 👻
Unmodified (2) 538 kB (0 B / +0%) 👻
Total (4) 2.03 MB (-322 B / -0.02%) ↘️
Generated by @jsenv/file-size-impact during Report bundle size#1857385782 on a35c6ea

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. LGTM!

@denniskigen denniskigen merged commit 0b8c897 into master Feb 17, 2022
@denniskigen denniskigen deleted the docs-api branch February 17, 2022 17:50
@ZacButko ZacButko mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants