Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): O3-1112: Offline actions don't display offline registered patients correctly #331

Merged
merged 2 commits into from
Feb 17, 2022

Conversation

manuelroemer
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests, or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Correctly display offline registered patients in the offline actions table.

Screenshots

grafik

Related Issue

https://issues.openmrs.org/browse/O3-1112

Other

@github-actions
Copy link
Contributor

File size impact

Merging fix/O3-1112 into master impact files as follow:

@openmrs/esm-devtools-app (+0.18%)
Files new size
packages/apps/esm-devtools-app/dist/217.js 323 kB (+610 B / +0.19%) ↗️
Unmodified (4) 25.2 kB (0 B / +0%) 👻
Total (5) 348 kB (+610 B / +0.18%) ↗️
@openmrs/esm-implementer-tools-app (+0.04%)
Files new size
packages/apps/esm-implementer-tools-app/dist/217.js 323 kB (+610 B / +0.19%) ↗️
Unmodified (16) 1.29 MB (0 B / +0%) 👻
Total (17) 1.61 MB (+610 B / +0.04%) ↗️
@openmrs/esm-login-app (+0.03%)
Files new size
packages/apps/esm-login-app/dist/217.js 323 kB (+610 B / +0.19%) ↗️
Unmodified (27) 1.61 MB (0 B / +0%) 👻
Total (28) 1.93 MB (+610 B / +0.03%) ↗️
@openmrs/esm-offline-tools-app (+0.03%)
Files new size
packages/apps/esm-offline-tools-app/dist/217.js 323 kB (+610 B / +0.19%) ↗️
packages/apps/esm-offline-tools-app/dist/236.js 1.48 kB (+140 B / +10.48%) ↗️
packages/apps/esm-offline-tools-app/dist/707.js 161 kB (+140 B / +0.09%) ↗️
Unmodified (23) 2.2 MB (0 B / +0%) 👻
Total (26) 2.69 MB (+890 B / +0.03%) ↗️
@openmrs/esm-primary-navigation-app (+0.03%)
Files new size
packages/apps/esm-primary-navigation-app/dist/217.js 323 kB (+610 B / +0.19%) ↗️
Unmodified (17) 1.74 MB (0 B / +0%) 👻
Total (18) 2.06 MB (+610 B / +0.03%) ↗️
@openmrs/esm-app-shell (+0.06%)
Files new size
packages/shell/esm-app-shell/dist/service-worker.js 164 kB (+632 B / +0.39%) ↗️
packages/shell/esm-app-shell/dist/openmrs.js 1.33 MB (+601 B / +0.05%) ↗️
Unmodified (2) 538 kB (0 B / +0%) 👻
Total (4) 2.03 MB (+1.23 kB / +0.06%) ↗️
Generated by @jsenv/file-size-impact during Report bundle size#1858092642 on 799888f

@github-actions
Copy link
Contributor

File size impact

Merging fix/O3-1112 into master impact files as follow:

@openmrs/esm-devtools-app (+0.18%)
Files new size
packages/apps/esm-devtools-app/dist/217.js 323 kB (+610 B / +0.19%) ↗️
Unmodified (4) 25.2 kB (0 B / +0%) 👻
Total (5) 348 kB (+610 B / +0.18%) ↗️
@openmrs/esm-implementer-tools-app (+0.04%)
Files new size
packages/apps/esm-implementer-tools-app/dist/217.js 323 kB (+610 B / +0.19%) ↗️
Unmodified (16) 1.29 MB (0 B / +0%) 👻
Total (17) 1.61 MB (+610 B / +0.04%) ↗️
@openmrs/esm-login-app (+0.03%)
Files new size
packages/apps/esm-login-app/dist/217.js 323 kB (+610 B / +0.19%) ↗️
Unmodified (27) 1.61 MB (0 B / +0%) 👻
Total (28) 1.93 MB (+610 B / +0.03%) ↗️
@openmrs/esm-offline-tools-app (+0.03%)
Files new size
packages/apps/esm-offline-tools-app/dist/217.js 323 kB (+610 B / +0.19%) ↗️
packages/apps/esm-offline-tools-app/dist/236.js 1.48 kB (+140 B / +10.48%) ↗️
packages/apps/esm-offline-tools-app/dist/707.js 161 kB (+140 B / +0.09%) ↗️
Unmodified (23) 2.2 MB (0 B / +0%) 👻
Total (26) 2.69 MB (+890 B / +0.03%) ↗️
@openmrs/esm-primary-navigation-app (+0.03%)
Files new size
packages/apps/esm-primary-navigation-app/dist/217.js 323 kB (+610 B / +0.19%) ↗️
Unmodified (17) 1.74 MB (0 B / +0%) 👻
Total (18) 2.06 MB (+610 B / +0.03%) ↗️
@openmrs/esm-app-shell (+0.06%)
Files new size
packages/shell/esm-app-shell/dist/service-worker.js 164 kB (+632 B / +0.39%) ↗️
packages/shell/esm-app-shell/dist/openmrs.js 1.33 MB (+601 B / +0.05%) ↗️
Unmodified (2) 538 kB (0 B / +0%) 👻
Total (4) 2.03 MB (+1.23 kB / +0.06%) ↗️
Generated by @jsenv/file-size-impact during Report bundle size#1858112279 on 896755c

@manuelroemer manuelroemer merged commit 324eb32 into openmrs:master Feb 17, 2022
@ZacButko ZacButko mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants