Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI FIX for searching UUIDs in implementer's tools(e.g. concepts, personattributetype) and better readability of data #334

Merged
merged 7 commits into from
Feb 22, 2022

Conversation

vasharma05
Copy link
Member

@vasharma05 vasharma05 commented Feb 22, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

I have improved the UI for the implementer tools' search box for concept/personattributetype UUIDs.

Screenshots

https://www.loom.com/share/b1cb0fa8d6a54cf8a7b77b11509e9dae
Before:
image
After:
image

  1. Better readability of data (object or array of objects)
    Before:
    image
    After:
    image

For an array of objects, I have added a count in front of objects for better readability
image

  1. Added "[" and "]" in an array of string or number, reason, empty arrays are now visible as [ ], instead of a blank value.
    image
    image

Related Issue

Other

@vasharma05 vasharma05 marked this pull request as draft February 22, 2022 18:42
@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2022

File size impact

Merging searching-uuid-fix into master impact files as follow:

@openmrs/esm-devtools-app (no impact)
Files new size
Unmodified (5) 348 kB (0 B / +0%) 👻
Total (5) 348 kB (0 B / +0%) 👻
@openmrs/esm-implementer-tools-app (-1.66%)
Files new size
packages/apps/esm-implementer-tools-app/dist/664.js 174 kB 👶
packages/apps/esm-implementer-tools-app/dist/389.js 25 kB 👶
packages/apps/esm-implementer-tools-app/dist/574.js 765 B (+14 B / +1.86%) ↗️
packages/apps/esm-implementer-tools-app/dist/307.js 2.45 kB (+1 B / +0.04%) ↗️
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js 10.4 kB (+1 B / +0.01%) ↗️
packages/apps/esm-implementer-tools-app/dist/865.js 31.8 kB (-1 B / -0%) ↘️
packages/apps/esm-implementer-tools-app/dist/434.js deleted (-25.1 kB)
packages/apps/esm-implementer-tools-app/dist/753.js deleted (-204 kB)
Unmodified (11) 1.52 MB (0 B / +0%) 👻
Total (19) 1.77 MB (-29.8 kB / -1.66%) ↘️
@openmrs/esm-login-app (no impact)
Files new size
Unmodified (28) 1.93 MB (0 B / +0%) 👻
Total (28) 1.93 MB (0 B / +0%) 👻
@openmrs/esm-offline-tools-app (no impact)
Files new size
Unmodified (26) 2.69 MB (0 B / +0%) 👻
Total (26) 2.69 MB (0 B / +0%) 👻
@openmrs/esm-primary-navigation-app (no impact)
Files new size
Unmodified (18) 2.06 MB (0 B / +0%) 👻
Total (18) 2.06 MB (0 B / +0%) 👻
@openmrs/esm-app-shell (no impact)
Files new size
packages/shell/esm-app-shell/dist/service-worker.js 164 kB (0 B / +0%) 👻
Unmodified (3) 1.86 MB (0 B / +0%) 👻
Total (4) 2.03 MB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during Report bundle size#1883742504 on 03adffe

@vasharma05 vasharma05 changed the title UI FIX for searching UUIDs in implementer's tools(e.g. concepts, personattributetype) UI FIX for searching UUIDs in implementer's tools(e.g. concepts, personattributetype) and better readability of data Feb 22, 2022
@vasharma05 vasharma05 marked this pull request as ready for review February 22, 2022 19:54
Copy link
Collaborator

@brandones brandones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you @vasharma05 !

@brandones brandones merged commit 6899556 into openmrs:master Feb 22, 2022
@ZacButko ZacButko mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants