-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI FIX for searching UUIDs in implementer's tools(e.g. concepts, personattributetype) and better readability of data #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File size impactMerging searching-uuid-fix into master impact files as follow: @openmrs/esm-devtools-app (no impact)
@openmrs/esm-implementer-tools-app (-1.66%)
@openmrs/esm-login-app (no impact)
@openmrs/esm-offline-tools-app (no impact)
@openmrs/esm-primary-navigation-app (no impact)
@openmrs/esm-app-shell (no impact)
|
vasharma05
changed the title
UI FIX for searching UUIDs in implementer's tools(e.g. concepts, personattributetype)
UI FIX for searching UUIDs in implementer's tools(e.g. concepts, personattributetype) and better readability of data
Feb 22, 2022
brandones
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful, thank you @vasharma05 !
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
I have improved the UI for the implementer tools' search box for concept/personattributetype UUIDs.
Screenshots
https://www.loom.com/share/b1cb0fa8d6a54cf8a7b77b11509e9dae
Before:
After:
Before:
After:
For an array of objects, I have added a count in front of objects for better readability
Related Issue
Other