-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
O3-953: Location picker does not show all locations #343
Conversation
@vasharma05 Very cool demo! |
File size impactMerging O3-953 into master impact files as follow: @openmrs/esm-devtools-app (no impact)
@openmrs/esm-implementer-tools-app (no impact)
@openmrs/esm-login-app (+0.61%)
@openmrs/esm-offline-tools-app (no impact)
@openmrs/esm-primary-navigation-app (no impact)
@openmrs/esm-app-shell (+0%)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments, but good work so far!
packages/apps/esm-login-app/src/choose-location/choose-location.component.tsx
Outdated
Show resolved
Hide resolved
packages/apps/esm-login-app/src/choose-location/choose-location.resource.ts
Outdated
Show resolved
Hide resolved
packages/apps/esm-login-app/src/choose-location/choose-location.resource.ts
Outdated
Show resolved
Hide resolved
packages/apps/esm-login-app/src/choose-location/choose-location.resource.ts
Outdated
Show resolved
Hide resolved
Hi @brandones, @ZacButko! |
I had a conversation with @denniskigen about helping me out with the writing tests. |
Hi @ZacButko! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please fix missing / excessive hook dependencies before merging
packages/apps/esm-login-app/src/choose-location/choose-location.resource.ts
Outdated
Show resolved
Hide resolved
packages/apps/esm-login-app/src/choose-location/choose-location.resource.ts
Outdated
Show resolved
Hide resolved
packages/apps/esm-login-app/src/location-picker/location-picker.component.tsx
Outdated
Show resolved
Hide resolved
packages/apps/esm-login-app/src/location-picker/location-picker.component.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more things. Nice work, though, Vineet!
packages/apps/esm-login-app/src/choose-location/choose-location.resource.ts
Outdated
Show resolved
Hide resolved
packages/apps/esm-login-app/src/location-picker/location-picker.component.scss
Outdated
Show resolved
Hide resolved
@ZacButko! Please have a review and if it looks good, please approve the PR. |
Tests to be added in subsequent PR |
Thank you @denniskigen for writing the tests at #361. |
Requirements
For changes to apps
If applicable
Summary
This PR is still a work in progress.
I have added infinite scroll to fetch the multiple sets of locations in the location picker. Along with that, I have added backend connectivity to the search bar.
Screenshots
https://www.awesomescreenshot.com/video/7704971?key=67e59ee20d21e2a45aac94fd502e19d9
Related Issue
https://issues.openmrs.org/browse/O3-953
Other