Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-1164 Should be able to edit config JSON in implementer tools #354

Merged
merged 3 commits into from
Mar 11, 2022

Conversation

brandones
Copy link
Collaborator

@brandones brandones commented Mar 11, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

This adds a JSON editor to the implementer tools. This makes it easy to edit the temporary config even in ways that the normal config editor doesn't yet support (such as configuring extensions).

Note to reviewers: The vast majority of the PR diff is refactor code. All of the refactoring is in the first commit. I strongly recommend reviewing by commit. The first commit you can just skim; it is just moving files around. The latter two are substantive.

Screenshots

json-editor

Related Issue

https://issues.openmrs.org/browse/O3-1164

@github-actions
Copy link
Contributor

File size impact

Merging json-editor into master impact files as follow:

@openmrs/esm-devtools-app (no impact)
Files new size
Unmodified (5) 428 kB (0 B / +0%) 👻
Total (5) 428 kB (0 B / +0%) 👻
@openmrs/esm-implementer-tools-app (+26.92%)
Files new size
packages/apps/esm-implementer-tools-app/dist/620.js 442 kB 👶
packages/apps/esm-implementer-tools-app/dist/371.js 216 kB 👶
packages/apps/esm-implementer-tools-app/dist/707.js 23.9 kB 👶
packages/apps/esm-implementer-tools-app/dist/683.js 10.3 kB 👶
packages/apps/esm-implementer-tools-app/dist/652.js 9.74 kB 👶
packages/apps/esm-implementer-tools-app/dist/494.js 6.98 kB 👶
packages/apps/esm-implementer-tools-app/dist/95.js 2.22 kB 👶
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js 10.7 kB (+365 B / +3.52%) ↗️
packages/apps/esm-implementer-tools-app/dist/307.js 2.7 kB (+252 B / +10.28%) ↗️
packages/apps/esm-implementer-tools-app/dist/319.js 817 B (+195 B / +31.35%) ↗️
packages/apps/esm-implementer-tools-app/dist/839.js 8.86 kB (-4 B / -0.05%) ↘️
packages/apps/esm-implementer-tools-app/dist/574.js 760 B (-5 B / -0.65%) ↘️
packages/apps/esm-implementer-tools-app/dist/237.js deleted (-2.53 kB)
packages/apps/esm-implementer-tools-app/dist/597.js 710 kB (-7.21 kB / -1.01%) ↘️
packages/apps/esm-implementer-tools-app/dist/865.js deleted (-31.8 kB)
packages/apps/esm-implementer-tools-app/dist/664.js deleted (-174 kB)
Unmodified (8) 897 kB (0 B / +0%) 👻
Total (24) 2.34 MB (+497 kB / +26.92%) ↗️
@openmrs/esm-login-app (no impact)
Files new size
Unmodified (28) 2.01 MB (0 B / +0%) 👻
Total (28) 2.01 MB (0 B / +0%) 👻
@openmrs/esm-offline-tools-app (+0%)
Files new size
packages/apps/esm-offline-tools-app/dist/574.js 2.13 kB (+3 B / +0.14%) ↗️
Unmodified (25) 2.77 MB (0 B / +0%) 👻
Total (26) 2.77 MB (+3 B / +0%) ↗️
@openmrs/esm-primary-navigation-app (no impact)
Files new size
Unmodified (18) 2.14 MB (0 B / +0%) 👻
Total (18) 2.14 MB (0 B / +0%) 👻
@openmrs/esm-app-shell (+0.02%)
Files new size
packages/shell/esm-app-shell/dist/service-worker.js 164 kB (+355 B / +0.22%) ↗️
Unmodified (3) 1.94 MB (0 B / +0%) 👻
Total (4) 2.11 MB (+355 B / +0.02%) ↗️
Generated by @jsenv/file-size-impact during Report bundle size#1966296667 on f837a35

@github-actions
Copy link
Contributor

File size impact

Merging json-editor into master impact files as follow:

@openmrs/esm-devtools-app (no impact)
Files new size
Unmodified (5) 428 kB (0 B / +0%) 👻
Total (5) 428 kB (0 B / +0%) 👻
@openmrs/esm-implementer-tools-app (+26.92%)
Files new size
packages/apps/esm-implementer-tools-app/dist/620.js 442 kB 👶
packages/apps/esm-implementer-tools-app/dist/371.js 216 kB 👶
packages/apps/esm-implementer-tools-app/dist/707.js 23.9 kB 👶
packages/apps/esm-implementer-tools-app/dist/683.js 10.3 kB 👶
packages/apps/esm-implementer-tools-app/dist/652.js 9.74 kB 👶
packages/apps/esm-implementer-tools-app/dist/494.js 6.98 kB 👶
packages/apps/esm-implementer-tools-app/dist/95.js 2.22 kB 👶
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js 10.7 kB (+365 B / +3.52%) ↗️
packages/apps/esm-implementer-tools-app/dist/307.js 2.7 kB (+252 B / +10.28%) ↗️
packages/apps/esm-implementer-tools-app/dist/319.js 817 B (+195 B / +31.35%) ↗️
packages/apps/esm-implementer-tools-app/dist/839.js 8.86 kB (-4 B / -0.05%) ↘️
packages/apps/esm-implementer-tools-app/dist/574.js 760 B (-5 B / -0.65%) ↘️
packages/apps/esm-implementer-tools-app/dist/237.js deleted (-2.53 kB)
packages/apps/esm-implementer-tools-app/dist/597.js 710 kB (-7.21 kB / -1.01%) ↘️
packages/apps/esm-implementer-tools-app/dist/865.js deleted (-31.8 kB)
packages/apps/esm-implementer-tools-app/dist/664.js deleted (-174 kB)
Unmodified (8) 897 kB (0 B / +0%) 👻
Total (24) 2.34 MB (+497 kB / +26.92%) ↗️
@openmrs/esm-login-app (no impact)
Files new size
Unmodified (28) 2.01 MB (0 B / +0%) 👻
Total (28) 2.01 MB (0 B / +0%) 👻
@openmrs/esm-offline-tools-app (+0%)
Files new size
packages/apps/esm-offline-tools-app/dist/574.js 2.13 kB (+3 B / +0.14%) ↗️
Unmodified (25) 2.77 MB (0 B / +0%) 👻
Total (26) 2.77 MB (+3 B / +0%) ↗️
@openmrs/esm-primary-navigation-app (no impact)
Files new size
Unmodified (18) 2.14 MB (0 B / +0%) 👻
Total (18) 2.14 MB (0 B / +0%) 👻
@openmrs/esm-app-shell (+0.02%)
Files new size
packages/shell/esm-app-shell/dist/service-worker.js 164 kB (+355 B / +0.22%) ↗️
Unmodified (3) 1.94 MB (0 B / +0%) 👻
Total (4) 2.11 MB (+355 B / +0.02%) ↗️
Generated by @jsenv/file-size-impact during Report bundle size#1966305102 on 1671246

Copy link
Member

@jonathandick jonathandick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an amazing addition to the implementer tools. Thanks @brandones

@brandones brandones merged commit fc34906 into master Mar 11, 2022
@brandones brandones deleted the json-editor branch March 11, 2022 16:42
@ZacButko ZacButko mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants