-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-1164 Should be able to edit config JSON in implementer tools #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File size impactMerging json-editor into master impact files as follow: @openmrs/esm-devtools-app (no impact)
@openmrs/esm-implementer-tools-app (+26.92%)
@openmrs/esm-login-app (no impact)
@openmrs/esm-offline-tools-app (+0%)
@openmrs/esm-primary-navigation-app (no impact)
@openmrs/esm-app-shell (+0.02%)
|
File size impactMerging json-editor into master impact files as follow: @openmrs/esm-devtools-app (no impact)
@openmrs/esm-implementer-tools-app (+26.92%)
@openmrs/esm-login-app (no impact)
@openmrs/esm-offline-tools-app (+0%)
@openmrs/esm-primary-navigation-app (no impact)
@openmrs/esm-app-shell (+0.02%)
|
jonathandick
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an amazing addition to the implementer tools. Thanks @brandones
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
This adds a JSON editor to the implementer tools. This makes it easy to edit the temporary config even in ways that the normal config editor doesn't yet support (such as configuring extensions).
Note to reviewers: The vast majority of the PR diff is refactor code. All of the refactoring is in the first commit. I strongly recommend reviewing by commit. The first commit you can just skim; it is just moving files around. The latter two are substantive.
Screenshots
Related Issue
https://issues.openmrs.org/browse/O3-1164