Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(enhancement) update useVisit hook #356

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Conversation

donaldkibet
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

  1. Update useVisit hook to return currentVisit as active visit when startDatetime is today and stopDatetime as null

Screenshots

Related Issue

Other

@github-actions
Copy link
Contributor

File size impact

Merging enhancement/active-visits into master impact files as follow:

@openmrs/esm-devtools-app (+0.1%)
Files new size
packages/apps/esm-devtools-app/dist/217.js 403 kB (+421 B / +0.1%) ↗️
Unmodified (4) 25.2 kB (0 B / +0%) 👻
Total (5) 428 kB (+421 B / +0.1%) ↗️
@openmrs/esm-implementer-tools-app (+0.02%)
Files new size
packages/apps/esm-implementer-tools-app/dist/217.js 403 kB (+421 B / +0.1%) ↗️
Unmodified (20) 1.94 MB (0 B / +0%) 👻
Total (21) 2.34 MB (+421 B / +0.02%) ↗️
@openmrs/esm-login-app (+0.02%)
Files new size
packages/apps/esm-login-app/dist/217.js 403 kB (+421 B / +0.1%) ↗️
Unmodified (27) 1.61 MB (0 B / +0%) 👻
Total (28) 2.01 MB (+421 B / +0.02%) ↗️
@openmrs/esm-offline-tools-app (+0.02%)
Files new size
packages/apps/esm-offline-tools-app/dist/217.js 403 kB (+421 B / +0.1%) ↗️
Unmodified (25) 2.37 MB (0 B / +0%) 👻
Total (26) 2.77 MB (+421 B / +0.02%) ↗️
@openmrs/esm-primary-navigation-app (+0.02%)
Files new size
packages/apps/esm-primary-navigation-app/dist/217.js 403 kB (+421 B / +0.1%) ↗️
Unmodified (17) 1.74 MB (0 B / +0%) 👻
Total (18) 2.14 MB (+421 B / +0.02%) ↗️
@openmrs/esm-app-shell (+0.32%)
Files new size
packages/shell/esm-app-shell/dist/86f000bf73a71ab2ed8e.js 9.56 kB 👶
packages/shell/esm-app-shell/dist/openmrs.js 1.41 MB (+6.68 kB / +0.48%) ↗️
packages/shell/esm-app-shell/dist/c6e919635c7485e14f27.js deleted (-9.56 kB)
packages/shell/esm-app-shell/dist/service-worker.js 164 kB (0 B / +0%) 👻
Unmodified (1) 528 kB (0 B / +0%) 👻
Total (5) 2.11 MB (+6.68 kB / +0.32%) ↗️
Generated by @jsenv/file-size-impact during Report bundle size#1982024195 on 0272791

@brandones brandones merged commit a4c0d4e into master Mar 14, 2022
@brandones brandones deleted the enhancement/active-visits branch March 14, 2022 17:42
@ZacButko ZacButko mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants