Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add support for extension config schemas #358

Merged
merged 4 commits into from
Mar 17, 2022

Conversation

brandones
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Currently, extensions inherit the configuration schemas of the modules in which they are defined. Some extensions (especially generic ones) have highly specific configuration requirements, which pollute the module config schema: see here in patient-chart.

This makes it so that extensions can have their own schema, apart from the module schema.

Unrelatedly, this removes some dead code. It is not used anywhere.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2022


Error: Error while trying to collect info after merging config-extension-schema into master.

Error: Command failed: git fetch --no-tags --prune origin config-extension-schema
fatal: couldn't find remote ref config-extension-schema

    at ChildProcess.exithandler (node:child_process:397:12)
    at ChildProcess.emit (node:events:394:28)
    at maybeClose (node:internal/child_process:1067:16)
    at Socket. (node:internal/child_process:453:11)
    at Socket.emit (node:events:394:28)
    at Pipe. (node:net:672:12)

Generated by @jsenv/file-size-impact during Report bundle size#2000498149 on bbdc9b5

Copy link
Member

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I really like this feature!

@brandones brandones merged commit caac917 into master Mar 17, 2022
@brandones brandones deleted the config-extension-schema branch March 17, 2022 19:38
@ZacButko ZacButko mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants