Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs) Update README to remove reference to lerna run build #395

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Apr 12, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Just a documentation change. I missed this in my initial PR for turbo support. yarn build should be a stable command that calls whatever build tool we're using.

Screenshots

Related Issue

Other

@github-actions
Copy link
Contributor

File size impact

Merging turbo-update-readme into master impact files as follow:

@openmrs/esm-devtools-app (no impact)
Files new size
Unmodified (5) 483 kB (0 B / +0%) 👻
Total (5) 483 kB (0 B / +0%) 👻
@openmrs/esm-implementer-tools-app (no impact)
Files new size
Unmodified (22) 2.44 MB (0 B / +0%) 👻
Total (22) 2.44 MB (0 B / +0%) 👻
@openmrs/esm-login-app (no impact)
Files new size
Unmodified (29) 2.09 MB (0 B / +0%) 👻
Total (29) 2.09 MB (0 B / +0%) 👻
@openmrs/esm-offline-tools-app (no impact)
Files new size
Unmodified (27) 2.84 MB (0 B / +0%) 👻
Total (27) 2.84 MB (0 B / +0%) 👻
@openmrs/esm-primary-navigation-app (no impact)
Files new size
Unmodified (18) 2.26 MB (0 B / +0%) 👻
Total (18) 2.26 MB (0 B / +0%) 👻
@openmrs/esm-app-shell (no impact)
Files new size
Unmodified (4) 2.19 MB (0 B / +0%) 👻
Total (4) 2.19 MB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during Report bundle size#2156770929 on 0a62bd2

@denniskigen denniskigen merged commit f5175c5 into master Apr 12, 2022
@denniskigen denniskigen deleted the turbo-update-readme branch April 12, 2022 22:28
@ZacButko ZacButko mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants