Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) O3-1262: Fix yarn:run-shell #396

Merged
merged 1 commit into from
Apr 13, 2022
Merged

(chore) O3-1262: Fix yarn:run-shell #396

merged 1 commit into from
Apr 13, 2022

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Apr 13, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Fixes yarn run:shell so it actually works.

Screenshots

Related Issue

Other

Copy link
Member

@manuelroemer manuelroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - the same changes also worked for me locally. Thanks Ian!

@github-actions
Copy link
Contributor


Error: Error while trying to collect info after merging O3-1262 into master.

Error: Command failed: git merge FETCH_HEAD --allow-unrelated-histories

    at ChildProcess.exithandler (node:child_process:397:12)
    at ChildProcess.emit (node:events:394:28)
    at maybeClose (node:internal/child_process:1067:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)

Generated by @jsenv/file-size-impact during Report bundle size#2161049123 on 5f6773b

@ibacher ibacher merged commit 7dbe0df into master Apr 13, 2022
@ibacher ibacher deleted the O3-1262 branch April 13, 2022 12:21
Copy link
Contributor

@prathamesh-mutkure prathamesh-mutkure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ibacher, it works for me now :)

@ZacButko ZacButko mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants