-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) openmrs tool should depend on pinned version of webpack-config #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibacher
force-pushed
the
stabilize_build
branch
from
April 13, 2022 15:30
656da12
to
9d2c851
Compare
ibacher
force-pushed
the
stabilize_build
branch
from
April 13, 2022 15:30
9d2c851
to
1ec93df
Compare
ZacButko
approved these changes
Apr 13, 2022
brandones
approved these changes
Apr 13, 2022
File size impactMerging stabilize_build into master impact files as follow: @openmrs/esm-devtools-app (no impact)
@openmrs/esm-implementer-tools-app (no impact)
@openmrs/esm-login-app (no impact)
@openmrs/esm-offline-tools-app (no impact)
@openmrs/esm-primary-navigation-app (no impact)
@openmrs/esm-app-shell (no impact)
|
File size impactMerging stabilize_build into master impact files as follow: @openmrs/esm-devtools-app (no impact)
@openmrs/esm-implementer-tools-app (no impact)
@openmrs/esm-login-app (no impact)
@openmrs/esm-offline-tools-app (no impact)
@openmrs/esm-primary-navigation-app (no impact)
@openmrs/esm-app-shell (no impact)
|
File size impactMerging stabilize_build into master impact files as follow: @openmrs/esm-devtools-app (no impact)
@openmrs/esm-implementer-tools-app (no impact)
@openmrs/esm-login-app (no impact)
@openmrs/esm-offline-tools-app (no impact)
@openmrs/esm-primary-navigation-app (no impact)
@openmrs/esm-app-shell (no impact)
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
This updates the
openmrs
tool to depend on a fixed version of@openmrs/webpack-config
updated every time theversion
command is run.Without enforcing fixed versions of dependencies on
@openmrs/*
dependencies, we can end up with conflicting transitive dependencies, especially when trying to pin things to non-released versions.Screenshots
Related Issue
Other