Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add showModal mock to esm-framework/mock #403

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

donaldkibet
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

This PR add showModal mock function to esm-framework/mock file

Screenshots

Related Issue

Other

@github-actions
Copy link
Contributor


Error: Error while trying to collect info after merging enhancement/style-guide-mock into master.

Error: Command failed: git merge FETCH_HEAD --allow-unrelated-histories

    at ChildProcess.exithandler (node:child_process:397:12)
    at ChildProcess.emit (node:events:394:28)
    at maybeClose (node:internal/child_process:1067:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)

Generated by @jsenv/file-size-impact during Report bundle size#2193726413 on 6bda750

@brandones brandones merged commit 8baf876 into master Apr 20, 2022
@brandones brandones deleted the enhancement/style-guide-mock branch April 20, 2022 17:22
@ZacButko ZacButko mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants