Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-1224 Tablet mode: Side navigation widgets fails to identify the user ID #406

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

brandones
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

This fixes the hack to make the side nav work in tablet mode. It was missing the patient info.

This is all a temporary hack; I am working on a better solution now but want to get this fix in quickly.

Screenshots

Peek 2022-04-21 14-30

Related Issue

https://issues.openmrs.org/browse/O3-1224

@github-actions
Copy link
Contributor


Error: Error while trying to collect info after merging sidenav-pt-uuid into master.

Error: Command failed: git merge FETCH_HEAD --allow-unrelated-histories

    at ChildProcess.exithandler (node:child_process:397:12)
    at ChildProcess.emit (node:events:394:28)
    at maybeClose (node:internal/child_process:1067:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)

Generated by @jsenv/file-size-impact during Report bundle size#2204481655 on f4bd939

Copy link
Member

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibacher ibacher merged commit a2370ec into master Apr 22, 2022
@ibacher ibacher deleted the sidenav-pt-uuid branch April 22, 2022 00:32
@ZacButko ZacButko mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants