Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create unified left nav system #410

Merged
merged 7 commits into from
Apr 26, 2022
Merged

Create unified left nav system #410

merged 7 commits into from
Apr 26, 2022

Conversation

brandones
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

This creates a left nav system which is unified across the application. Frontends need only to mount the component and tell it what the current navigation context is.

Screenshots

No UI changes.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2022


Error: Error while trying to collect info after merging left-nav-refactor into master.

Error: Command failed: git merge FETCH_HEAD --allow-unrelated-histories

    at ChildProcess.exithandler (node:child_process:397:12)
    at ChildProcess.emit (node:events:394:28)
    at maybeClose (node:internal/child_process:1067:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)

Generated by @jsenv/file-size-impact during Report bundle size#2228069626 on 9ee41f9

Copy link
Contributor

@ZacButko ZacButko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really excited for this. Thank you for doing this.

@brandones brandones merged commit e0e5d68 into master Apr 26, 2022
@brandones brandones deleted the left-nav-refactor branch April 26, 2022 16:52
@ZacButko ZacButko mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants