Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs) Fix headers for GitHub Docs site #412

Merged
merged 1 commit into from
Apr 26, 2022
Merged

(docs) Fix headers for GitHub Docs site #412

merged 1 commit into from
Apr 26, 2022

Conversation

brandones
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Markdown link check still broken after #411 . This fixes the headers. Don't merge it until it's passing that check.

@github-actions
Copy link
Contributor

File size impact

Merging fix-docs-2 into master impact files as follow:

@openmrs/esm-devtools-app (no impact)
Files new size
Unmodified (5) 483 kB (0 B / +0%) 👻
Total (5) 483 kB (0 B / +0%) 👻
@openmrs/esm-implementer-tools-app (no impact)
Files new size
Unmodified (22) 2.44 MB (0 B / +0%) 👻
Total (22) 2.44 MB (0 B / +0%) 👻
@openmrs/esm-login-app (no impact)
Files new size
Unmodified (29) 2.09 MB (0 B / +0%) 👻
Total (29) 2.09 MB (0 B / +0%) 👻
@openmrs/esm-offline-tools-app (no impact)
Files new size
Unmodified (28) 2.84 MB (0 B / +0%) 👻
Total (28) 2.84 MB (0 B / +0%) 👻
@openmrs/esm-primary-navigation-app (no impact)
Files new size
Unmodified (18) 2.26 MB (0 B / +0%) 👻
Total (18) 2.26 MB (0 B / +0%) 👻
@openmrs/esm-app-shell (no impact)
Files new size
Unmodified (4) 2.19 MB (0 B / +0%) 👻
Total (4) 2.19 MB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during Report bundle size#2227718551 on 1149946

@ibacher ibacher merged commit cb5e7c4 into master Apr 26, 2022
@ibacher ibacher deleted the fix-docs-2 branch April 26, 2022 18:06
@ibacher
Copy link
Member

ibacher commented Apr 26, 2022

Ok... bizarrely it worked on the PR itself, but not on merge? This also seems like such a weird thing to need to supply.

@brandones
Copy link
Collaborator Author

Looks like it worked when you re-ran it. Thanks for doing that: https://github.com/openmrs/openmrs-esm-core/actions/runs/2228498245

See tcort/markdown-link-check#201 about this issue

@ZacButko ZacButko mentioned this pull request May 3, 2022
lgruen added a commit to populationgenomics/team-docs that referenced this pull request Jul 26, 2022
lgruen added a commit to populationgenomics/team-docs that referenced this pull request Jul 26, 2022
…ion (#122)

* Line up Hail notebook Docker image version tag with Hail release version

* Work around issue in link checker for GitHub internal links

See openmrs/openmrs-esm-core#412

* Fix pylint link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants