Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary and conflicting type definitions #448

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Jun 1, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Removes two typing constants for Webpack Module Federation. As I understand things, Webpack will provide those, so this PR just switches the one place we need to know about them to use Webpacks own type-bindings.

Basically, this should be a zero-impact typescript-only change.

Screenshots

Related Issue

Other

Why I'm proposing this: https://openmrs.slack.com/archives/CHP5QAE5R/p1654017468812849

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022


Error: Error while trying to collect info before merging fix/webpack-global-typings into master.

TypeError: directoryUrl must be a string or an url, received undefined
    at assertAndNormalizeDirectoryUrl (file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/@jsenv/filesystem/src/assertAndNormalizeDirectoryUrl.js:23:11)
    at generateFileSizeReport (file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/@jsenv/file-size-impact/src/generateFileSizeReport.js:26:22)
    at file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/tools/size-generator.mjs:41:37

Generated by @jsenv/file-size-impact during Report bundle size#2423938005 on 1918ba3

@ibacher ibacher merged commit f190b3d into master Jun 2, 2022
@ibacher ibacher deleted the fix/webpack-global-typings branch June 2, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants