Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-1294:User should be able to navigate back to username screen #449

Merged
merged 4 commits into from
Jun 7, 2022
Merged

O3-1294:User should be able to navigate back to username screen #449

merged 4 commits into from
Jun 7, 2022

Conversation

jwnasambu
Copy link
Contributor

@jwnasambu jwnasambu commented Jun 2, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

A user is able to navigate from the password input screen to the username input screen to modify their username.

Screenshots

screencast.2022-06-03.3.AM-00-47.mp4

Related Issue

Other

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022


Error: Error while trying to collect info before merging O3-1294 into master.

TypeError: directoryUrl must be a string or an url, received undefined
    at assertAndNormalizeDirectoryUrl (file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/@jsenv/filesystem/src/assertAndNormalizeDirectoryUrl.js:23:11)
    at generateFileSizeReport (file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/@jsenv/file-size-impact/src/generateFileSizeReport.js:26:22)
    at file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/tools/size-generator.mjs:41:37

Generated by @jsenv/file-size-impact during Report bundle size#2453588358 on a420120

@CynthiaKamau
Copy link
Contributor

LGTM!

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @jwnasambu. I've left a few suggestions.

packages/apps/esm-login-app/src/login/login.component.tsx Outdated Show resolved Hide resolved
packages/apps/esm-login-app/src/styles.scss Outdated Show resolved Hide resolved
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwnasambu Please use a different commit message for fixing up the work.

packages/apps/esm-login-app/src/styles.scss Outdated Show resolved Hide resolved
@denniskigen denniskigen merged commit dca9f42 into openmrs:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants