Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix back button altering position of card #455

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Fix back button altering position of card #455

merged 2 commits into from
Jun 21, 2022

Conversation

jwnasambu
Copy link
Contributor

@jwnasambu jwnasambu commented Jun 16, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Fixed the back button not to alter the position of a login card when clicked.

Screenshots

screencast.2022-06-16.10.PM-42-58.mp4

Related Issue

https://issues.openmrs.org/browse/O3-1294

Other

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2022


Error: Error while trying to collect info before merging fix_back_button_altering_position_of_card into master.

TypeError: directoryUrl must be a string or an url, received undefined
    at assertAndNormalizeDirectoryUrl (file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/@jsenv/filesystem/src/assertAndNormalizeDirectoryUrl.js:23:11)
    at generateFileSizeReport (file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/@jsenv/file-size-impact/src/generateFileSizeReport.js:26:22)
    at file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/tools/size-generator.mjs:41:37

Generated by @jsenv/file-size-impact during Report bundle size#2511489158 on 7613e30

@github-actions
Copy link
Contributor


Error: Error while trying to collect info before merging fix_back_button_altering_position_of_card into master.

TypeError: directoryUrl must be a string or an url, received undefined
    at assertAndNormalizeDirectoryUrl (file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/@jsenv/filesystem/src/assertAndNormalizeDirectoryUrl.js:23:11)
    at generateFileSizeReport (file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/@jsenv/file-size-impact/src/generateFileSizeReport.js:26:22)
    at file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/tools/size-generator.mjs:41:37

Generated by @jsenv/file-size-impact during Report bundle size#2511431555 on d9b6ef7

Copy link
Contributor

@ZacButko ZacButko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks @jwnasambu

@ZacButko ZacButko merged commit bd41cf6 into openmrs:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants