-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global button for opening Implementer Tools #482
Conversation
Error: Error while trying to collect info after merging global-implementer-tools-button into master. Error: git merge command failed (is there a merge conflict?) at commentPrImpact (file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/@jsenv/github-pull-request-impact/src/commentGitHubPullRequestImpact.js:314:13) at processTicksAndRejections (node:internal/process/task_queues:96:5) at async commentGitHubPullRequestImpact (file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/@jsenv/github-pull-request-impact/src/commentGitHubPullRequestImpact.js:82:12) at async file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/tools/size-reporter.mjs:6:1 Generated by @jsenv/file-size-impact during Report bundle size#2696700868 on 01c9638 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Awesome, thank you @vasharma05 ! Since we haven't yet switched to having the implementer tools wrap around the screen, should we put the button at the bottom of the screen instead? |
Hi @brandones! |
I'm actually on board with @brandones 's suggestion. Basically what the button does now is to "pop up" the implementer tools from the bottom on the screen. Then it makes sense that the button to open them is on the bottom. I think everything else is agreed on, this would just be moving the action button from the top of the page to the bottom. @vasharma05 what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩
Requirements
For changes to apps
If applicable
Summary
I have made a global button for opening and closing the implementer tools in the application. Currently, we are not able to open the Implementer tools in the patient chart, due to the visit header. Seeing the designs in here, I have made a global button for the same.
Screenshots
Related Issue
Other