Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global button for opening Implementer Tools #482

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

vasharma05
Copy link
Member

@vasharma05 vasharma05 commented Jul 18, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

I have made a global button for opening and closing the implementer tools in the application. Currently, we are not able to open the Implementer tools in the patient chart, due to the visit header. Seeing the designs in here, I have made a global button for the same.

Screenshots

Screenshot 2022-07-19 at 3 13 47 PM

Screenshot 2022-07-19 at 3 13 55 PM

Screenshot 2022-07-19 at 3 14 05 PM

Screenshot 2022-07-19 at 3 14 17 PM

Related Issue

Other

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2022


Error: Error while trying to collect info after merging global-implementer-tools-button into master.

Error: git merge command failed (is there a merge conflict?)
    at commentPrImpact (file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/@jsenv/github-pull-request-impact/src/commentGitHubPullRequestImpact.js:314:13)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async commentGitHubPullRequestImpact (file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/@jsenv/github-pull-request-impact/src/commentGitHubPullRequestImpact.js:82:12)
    at async file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/tools/size-reporter.mjs:6:1

Generated by @jsenv/file-size-impact during Report bundle size#2696700868 on 01c9638

Copy link
Contributor

@ZacButko ZacButko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@brandones
Copy link
Collaborator

Awesome, thank you @vasharma05 !

Since we haven't yet switched to having the implementer tools wrap around the screen, should we put the button at the bottom of the screen instead?

@vasharma05
Copy link
Member Author

Hi @brandones!
Actually we need to put the button for the visit header on the patient chart, since the user is not able to access the implementer tools in the patient chart. As discussed with @ZacButko, he suggested that since we'll be implementing this button for only visit header, and we have to keep this button everywhere as per design, why not to keep it for the whole application.

@ZacButko
Copy link
Contributor

I'm actually on board with @brandones 's suggestion. Basically what the button does now is to "pop up" the implementer tools from the bottom on the screen. Then it makes sense that the button to open them is on the bottom. I think everything else is agreed on, this would just be moving the action button from the top of the page to the bottom. @vasharma05 what do you think?

Copy link
Contributor

@ZacButko ZacButko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@vasharma05 vasharma05 merged commit 6836764 into master Jul 21, 2022
@vasharma05 vasharma05 deleted the global-implementer-tools-button branch July 21, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants