Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Fix error that appears when changing locale #560

Merged
merged 1 commit into from
Oct 31, 2022
Merged

(fix) Fix error that appears when changing locale #560

merged 1 commit into from
Oct 31, 2022

Commits on Oct 31, 2022

  1. (fix) Fix error that appears when changing locale 

    Presently, when a user changes their locale, a error notification appears on the screen. This error appears to be linked to the `getSessionLocation` function defined in `current-user.ts`. Specifically, it appears that this function tries to unsubscribe from an observable whose value is occasionally `undefined`.

This PR moves the subscription's `unsubscribe` call outside of the observable definition, ensuring it doesn't called on an object that might not exist.
    @denniskigen
    denniskigen committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    1b8f694 View commit details
    Browse the repository at this point in the history