Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Remove special handling for "core" apps and adjust docs to match #573

Merged
merged 1 commit into from
Nov 23, 2022
Merged

(feat) Remove special handling for "core" apps and adjust docs to match #573

merged 1 commit into from
Nov 23, 2022

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Nov 22, 2022 •
edited by denniskigen
Loading

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • [] I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Really, this might be seen as an anti-feature... This just removes the shell's special-casing for core applications and updates the repo docs to match the new reality.

@github-actions
Copy link
Contributor

Size Change: -1.33 MB (-39%) 🎉

Total Size: 2.09 MB

Filename Size Change
packages/shell/esm-app-shell/dist/esm-devtools-app/733.js 0 B -3.55 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-devtools-app/735.js 0 B -2.63 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-devtools-app/889.js 0 B -114 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-devtools-app/main.js 0 B -2.87 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-devtools-app/openmrs-esm-devtools-app.js 0 B -3.02 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/102.js 0 B -2.76 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/146.js 0 B -6.71 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/190.js 0 B -61.1 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/246.js 0 B -1.14 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/280.js 0 B -3.45 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/284.js 0 B -1.46 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/406.js 0 B -11.6 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/519.js 0 B -2.36 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/531.js 0 B -1.49 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/542.js 0 B -2.04 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/620.js 0 B -126 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/626.js 0 B -4.97 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/735.js 0 B -2.63 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/769.js 0 B -11.7 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/788.js 0 B -42.9 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/889.js 0 B -114 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/main.js 0 B -3.94 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/openmrs-esm-implementer-tools-app.js 0 B -3.25 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/390.js 0 B -597 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/406.js 0 B -1.13 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/420.js 0 B -1.61 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/50.js 0 B -6.15 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/581.js 0 B -24 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/607.js 0 B -3.92 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/611.js 0 B -720 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/735.js 0 B -2.63 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/759.js 0 B -16.5 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/788.js 0 B -42.9 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/889.js 0 B -114 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/897.js 0 B -5.14 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/925.js 0 B -6.65 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/951.js 0 B -1.31 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/main.js 0 B -3.29 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/openmrs-esm-login-app.js 0 B -3.16 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/106.js 0 B -7.41 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/126.js 0 B -1.35 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/259.js 0 B -2.74 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/316.js 0 B -3.56 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/373.js 0 B -2.73 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/386.js 0 B -51.2 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/412.js 0 B -3.79 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/456.js 0 B -1.89 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/518.js 0 B -2.1 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/574.js 0 B -996 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/58.js 0 B -1.99 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/735.js 0 B -2.63 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/740.js 0 B -4.55 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/759.js 0 B -16.5 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/788.js 0 B -42.9 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/795.js 0 B -5.55 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/889.js 0 B -114 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/925.js 0 B -6.66 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/996.js 0 B -5.8 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/main.js 0 B -52.3 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/openmrs-esm-offline-tools-app.js 0 B -3.25 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-primary-navigation-app/146.js 0 B -6.71 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-primary-navigation-app/216.js 0 B -544 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-primary-navigation-app/34.js 0 B -3.03 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-primary-navigation-app/473.js 0 B -1.16 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-primary-navigation-app/483.js 0 B -11.4 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-primary-navigation-app/656.js 0 B -5.5 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-primary-navigation-app/710.js 0 B -6.28 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-primary-navigation-app/723.js 0 B -4.49 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-primary-navigation-app/735.js 0 B -2.63 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-primary-navigation-app/787.js 0 B -9.38 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-primary-navigation-app/788.js 0 B -42.9 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-primary-navigation-app/889.js 0 B -114 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-primary-navigation-app/98.js 0 B -2.19 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-primary-navigation-app/main.js 0 B -9.39 kB (removed) 🏆
packages/shell/esm-app-shell/dist/esm-primary-navigation-app/openmrs-esm-primary-navigation-app.js 0 B -3.25 kB (removed) 🏆
packages/shell/esm-app-shell/dist/service-worker.js 51.1 kB -3.67 kB (-7%) ✅
ℹ️ View Unchanged
Filename Size Change
packages/apps/esm-devtools-app/dist/733.js 3.55 kB 0 B
packages/apps/esm-devtools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-devtools-app/dist/889.js 114 kB 0 B
packages/apps/esm-devtools-app/dist/988.js 363 B 0 B
packages/apps/esm-devtools-app/dist/main.js 2.87 kB 0 B
packages/apps/esm-devtools-app/dist/openmrs-esm-devtools-app.js 3.04 kB 0 B
packages/apps/esm-implementer-tools-app/dist/102.js 2.76 kB 0 B
packages/apps/esm-implementer-tools-app/dist/146.js 6.71 kB 0 B
packages/apps/esm-implementer-tools-app/dist/190.js 61.1 kB 0 B
packages/apps/esm-implementer-tools-app/dist/246.js 1.14 kB 0 B
packages/apps/esm-implementer-tools-app/dist/280.js 3.46 kB 0 B
packages/apps/esm-implementer-tools-app/dist/284.js 1.46 kB 0 B
packages/apps/esm-implementer-tools-app/dist/319.js 454 B 0 B
packages/apps/esm-implementer-tools-app/dist/406.js 11.6 kB 0 B
packages/apps/esm-implementer-tools-app/dist/519.js 2.36 kB 0 B
packages/apps/esm-implementer-tools-app/dist/531.js 1.49 kB 0 B
packages/apps/esm-implementer-tools-app/dist/542.js 2.04 kB 0 B
packages/apps/esm-implementer-tools-app/dist/574.js 428 B 0 B
packages/apps/esm-implementer-tools-app/dist/620.js 126 kB 0 B
packages/apps/esm-implementer-tools-app/dist/626.js 5.06 kB 0 B
packages/apps/esm-implementer-tools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-implementer-tools-app/dist/769.js 11.8 kB 0 B
packages/apps/esm-implementer-tools-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-implementer-tools-app/dist/889.js 114 kB 0 B
packages/apps/esm-implementer-tools-app/dist/main.js 3.94 kB 0 B
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js 3.26 kB 0 B
packages/apps/esm-login-app/dist/236.js 268 B 0 B
packages/apps/esm-login-app/dist/240.js 359 B 0 B
packages/apps/esm-login-app/dist/272.js 260 B 0 B
packages/apps/esm-login-app/dist/319.js 356 B 0 B
packages/apps/esm-login-app/dist/336.js 224 B 0 B
packages/apps/esm-login-app/dist/390.js 597 B 0 B
packages/apps/esm-login-app/dist/406.js 1.13 kB 0 B
packages/apps/esm-login-app/dist/420.js 1.61 kB 0 B
packages/apps/esm-login-app/dist/50.js 6.18 kB 0 B
packages/apps/esm-login-app/dist/539.js 294 B 0 B
packages/apps/esm-login-app/dist/574.js 443 B 0 B
packages/apps/esm-login-app/dist/581.js 23.9 kB 0 B
packages/apps/esm-login-app/dist/607.js 3.92 kB 0 B
packages/apps/esm-login-app/dist/611.js 720 B 0 B
packages/apps/esm-login-app/dist/644.js 299 B 0 B
packages/apps/esm-login-app/dist/673.js 278 B 0 B
packages/apps/esm-login-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-login-app/dist/757.js 293 B 0 B
packages/apps/esm-login-app/dist/759.js 16.5 kB 0 B
packages/apps/esm-login-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-login-app/dist/889.js 114 kB 0 B
packages/apps/esm-login-app/dist/897.js 5.14 kB 0 B
packages/apps/esm-login-app/dist/925.js 6.66 kB 0 B
packages/apps/esm-login-app/dist/951.js 1.31 kB 0 B
packages/apps/esm-login-app/dist/main.js 3.29 kB 0 B
packages/apps/esm-login-app/dist/openmrs-esm-login-app.js 3.18 kB 0 B
packages/apps/esm-offline-tools-app/dist/106.js 7.43 kB 0 B
packages/apps/esm-offline-tools-app/dist/126.js 1.35 kB 0 B
packages/apps/esm-offline-tools-app/dist/259.js 2.76 kB 0 B
packages/apps/esm-offline-tools-app/dist/290.js 434 B 0 B
packages/apps/esm-offline-tools-app/dist/316.js 3.56 kB 0 B
packages/apps/esm-offline-tools-app/dist/373.js 2.83 kB 0 B
packages/apps/esm-offline-tools-app/dist/386.js 51.2 kB 0 B
packages/apps/esm-offline-tools-app/dist/391.js 299 B 0 B
packages/apps/esm-offline-tools-app/dist/412.js 3.85 kB 0 B
packages/apps/esm-offline-tools-app/dist/456.js 1.89 kB 0 B
packages/apps/esm-offline-tools-app/dist/518.js 2.1 kB 0 B
packages/apps/esm-offline-tools-app/dist/541.js 379 B 0 B
packages/apps/esm-offline-tools-app/dist/574.js 996 B 0 B
packages/apps/esm-offline-tools-app/dist/58.js 1.99 kB 0 B
packages/apps/esm-offline-tools-app/dist/733.js 285 B 0 B
packages/apps/esm-offline-tools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-offline-tools-app/dist/740.js 4.57 kB 0 B
packages/apps/esm-offline-tools-app/dist/759.js 16.5 kB 0 B
packages/apps/esm-offline-tools-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-offline-tools-app/dist/795.js 5.55 kB 0 B
packages/apps/esm-offline-tools-app/dist/889.js 114 kB 0 B
packages/apps/esm-offline-tools-app/dist/925.js 6.66 kB 0 B
packages/apps/esm-offline-tools-app/dist/967.js 489 B 0 B
packages/apps/esm-offline-tools-app/dist/996.js 5.88 kB 0 B
packages/apps/esm-offline-tools-app/dist/main.js 52.3 kB 0 B
packages/apps/esm-offline-tools-app/dist/openmrs-esm-offline-tools-app.js 3.26 kB 0 B
packages/apps/esm-primary-navigation-app/dist/146.js 6.72 kB 0 B
packages/apps/esm-primary-navigation-app/dist/216.js 544 B 0 B
packages/apps/esm-primary-navigation-app/dist/34.js 3.03 kB 0 B
packages/apps/esm-primary-navigation-app/dist/414.js 461 B 0 B
packages/apps/esm-primary-navigation-app/dist/473.js 1.16 kB 0 B
packages/apps/esm-primary-navigation-app/dist/483.js 11.4 kB 0 B
packages/apps/esm-primary-navigation-app/dist/574.js 178 B 0 B
packages/apps/esm-primary-navigation-app/dist/656.js 5.51 kB 0 B
packages/apps/esm-primary-navigation-app/dist/710.js 6.28 kB 0 B
packages/apps/esm-primary-navigation-app/dist/723.js 4.52 kB 0 B
packages/apps/esm-primary-navigation-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-primary-navigation-app/dist/787.js 9.38 kB 0 B
packages/apps/esm-primary-navigation-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-primary-navigation-app/dist/889.js 114 kB 0 B
packages/apps/esm-primary-navigation-app/dist/98.js 2.2 kB 0 B
packages/apps/esm-primary-navigation-app/dist/main.js 9.39 kB 0 B
packages/apps/esm-primary-navigation-app/dist/openmrs-esm-primary-navigation-app.js 3.27 kB 0 B
packages/framework/esm-api/dist/openmrs-esm-api.js 9.44 kB 0 B
packages/framework/esm-breadcrumbs/dist/openmrs-esm-breadcrumbs.js 3.24 kB 0 B
packages/framework/esm-config/dist/openmrs-esm-module-config.js 7.97 kB 0 B
packages/framework/esm-error-handling/dist/openmrs-esm-error-handling.js 1.41 kB 0 B
packages/framework/esm-extensions/dist/openmrs-esm-extensions.js 8.45 kB 0 B
packages/framework/esm-framework/dist/openmrs-esm-framework.js 211 kB 0 B
packages/framework/esm-globals/dist/openmrs-esm-globals.js 1.59 kB 0 B
packages/framework/esm-offline/dist/openmrs-esm-offline.js 35 kB 0 B
packages/framework/esm-react-utils/dist/openmrs-esm-react-utils.js 22.5 kB 0 B
packages/framework/esm-state/dist/openmrs-esm-state.js 1.47 kB 0 B
packages/framework/esm-styleguide/dist/openmrs-esm-styleguide.js 19.1 kB 0 B
packages/framework/esm-utils/dist/openmrs-esm-utils.js 10.8 kB 0 B
packages/shell/esm-app-shell/dist/2612cb727bcdbd5a3d87.js 923 B 0 B
packages/shell/esm-app-shell/dist/esm-devtools-app/988.js 0 B -363 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/319.js 0 B -454 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-implementer-tools-app/574.js 0 B -428 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/236.js 0 B -268 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/240.js 0 B -359 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/272.js 0 B -260 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/319.js 0 B -356 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/336.js 0 B -224 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/539.js 0 B -294 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/574.js 0 B -443 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/644.js 0 B -299 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/673.js 0 B -278 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-login-app/757.js 0 B -293 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/290.js 0 B -434 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/391.js 0 B -299 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/541.js 0 B -379 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/733.js 0 B -285 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-offline-tools-app/967.js 0 B -489 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-primary-navigation-app/414.js 0 B -461 B (removed) 🏆
packages/shell/esm-app-shell/dist/esm-primary-navigation-app/574.js 0 B -178 B (removed) 🏆
packages/shell/esm-app-shell/dist/openmrs.js 354 kB 0 B
packages/tooling/openmrs/dist/cli.js 2.99 kB 0 B
packages/tooling/openmrs/dist/commands/assemble.js 2.23 kB 0 B
packages/tooling/openmrs/dist/commands/build.js 2.26 kB 0 B
packages/tooling/openmrs/dist/commands/debug.js 539 B 0 B
packages/tooling/openmrs/dist/commands/develop.js 1.66 kB 0 B
packages/tooling/openmrs/dist/commands/index.js 360 B 0 B
packages/tooling/openmrs/dist/commands/start.js 848 B 0 B
packages/tooling/openmrs/dist/index.js 445 B 0 B
packages/tooling/openmrs/dist/runner.js 799 B 0 B
packages/tooling/openmrs/dist/utils/config.js 639 B 0 B
packages/tooling/openmrs/dist/utils/debugger.js 529 B 0 B
packages/tooling/openmrs/dist/utils/dependencies.js 300 B 0 B
packages/tooling/openmrs/dist/utils/helpers.js 275 B 0 B
packages/tooling/openmrs/dist/utils/importmap.js 2.79 kB 0 B
packages/tooling/openmrs/dist/utils/index.js 370 B 0 B
packages/tooling/openmrs/dist/utils/logger.js 234 B 0 B
packages/tooling/openmrs/dist/utils/untar.js 648 B 0 B
packages/tooling/openmrs/dist/utils/variables.js 192 B 0 B
packages/tooling/openmrs/dist/utils/webpack.js 276 B 0 B
packages/tooling/webpack-config/dist/index.js 3.01 kB 0 B
packages/tooling/webpack-config/dist/optimize.js 1.79 kB 0 B

compressed-size-action

denniskigen
denniskigen approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ibacher!

@ibacher ibacher merged commit 290da70 into main Nov 23, 2022
@ibacher ibacher deleted the feat/remove-core-apps branch November 23, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen denniskigen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibacher @denniskigen