Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs) Update an outdated FAQ about importmaps #602

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Feb 1, 2023

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Since we no longer embed a version of the importmap in the app-shell the FAQ item here no longer applies. However, I suppose there's some utility in having an explicit note about how to set the import map, so I've re-worded things.

Screenshots

Related Issue

Other

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Size Change: 0 B

Total Size: 2.05 MB

ℹ️ View Unchanged
Filename Size
packages/apps/esm-devtools-app/dist/733.js 3.55 kB
packages/apps/esm-devtools-app/dist/735.js 2.63 kB
packages/apps/esm-devtools-app/dist/889.js 109 kB
packages/apps/esm-devtools-app/dist/988.js 362 B
packages/apps/esm-devtools-app/dist/main.js 2.87 kB
packages/apps/esm-devtools-app/dist/openmrs-esm-devtools-app.js 3.04 kB
packages/apps/esm-implementer-tools-app/dist/102.js 2.76 kB
packages/apps/esm-implementer-tools-app/dist/146.js 6.71 kB
packages/apps/esm-implementer-tools-app/dist/246.js 1.14 kB
packages/apps/esm-implementer-tools-app/dist/280.js 3.46 kB
packages/apps/esm-implementer-tools-app/dist/284.js 1.46 kB
packages/apps/esm-implementer-tools-app/dist/319.js 454 B
packages/apps/esm-implementer-tools-app/dist/406.js 11.8 kB
packages/apps/esm-implementer-tools-app/dist/519.js 2.36 kB
packages/apps/esm-implementer-tools-app/dist/531.js 1.49 kB
packages/apps/esm-implementer-tools-app/dist/542.js 2.04 kB
packages/apps/esm-implementer-tools-app/dist/574.js 421 B
packages/apps/esm-implementer-tools-app/dist/620.js 126 kB
packages/apps/esm-implementer-tools-app/dist/626.js 5.06 kB
packages/apps/esm-implementer-tools-app/dist/684.js 61.8 kB
packages/apps/esm-implementer-tools-app/dist/697.js 11.7 kB
packages/apps/esm-implementer-tools-app/dist/735.js 2.63 kB
packages/apps/esm-implementer-tools-app/dist/788.js 42.9 kB
packages/apps/esm-implementer-tools-app/dist/889.js 109 kB
packages/apps/esm-implementer-tools-app/dist/main.js 3.94 kB
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js 3.26 kB
packages/apps/esm-login-app/dist/236.js 268 B
packages/apps/esm-login-app/dist/240.js 359 B
packages/apps/esm-login-app/dist/272.js 260 B
packages/apps/esm-login-app/dist/319.js 356 B
packages/apps/esm-login-app/dist/336.js 224 B
packages/apps/esm-login-app/dist/390.js 597 B
packages/apps/esm-login-app/dist/406.js 1.13 kB
packages/apps/esm-login-app/dist/420.js 1.61 kB
packages/apps/esm-login-app/dist/539.js 294 B
packages/apps/esm-login-app/dist/574.js 443 B
packages/apps/esm-login-app/dist/581.js 23.9 kB
packages/apps/esm-login-app/dist/607.js 3.92 kB
packages/apps/esm-login-app/dist/611.js 720 B
packages/apps/esm-login-app/dist/644.js 299 B
packages/apps/esm-login-app/dist/673.js 278 B
packages/apps/esm-login-app/dist/735.js 2.63 kB
packages/apps/esm-login-app/dist/757.js 293 B
packages/apps/esm-login-app/dist/759.js 16.5 kB
packages/apps/esm-login-app/dist/788.js 42.9 kB
packages/apps/esm-login-app/dist/889.js 109 kB
packages/apps/esm-login-app/dist/897.js 5.18 kB
packages/apps/esm-login-app/dist/925.js 6.66 kB
packages/apps/esm-login-app/dist/951.js 1.31 kB
packages/apps/esm-login-app/dist/98.js 5.71 kB
packages/apps/esm-login-app/dist/main.js 3.3 kB
packages/apps/esm-login-app/dist/openmrs-esm-login-app.js 3.19 kB
packages/apps/esm-offline-tools-app/dist/106.js 7.44 kB
packages/apps/esm-offline-tools-app/dist/126.js 1.35 kB
packages/apps/esm-offline-tools-app/dist/259.js 2.76 kB
packages/apps/esm-offline-tools-app/dist/290.js 434 B
packages/apps/esm-offline-tools-app/dist/316.js 3.57 kB
packages/apps/esm-offline-tools-app/dist/373.js 2.83 kB
packages/apps/esm-offline-tools-app/dist/386.js 51.2 kB
packages/apps/esm-offline-tools-app/dist/391.js 299 B
packages/apps/esm-offline-tools-app/dist/412.js 3.85 kB
packages/apps/esm-offline-tools-app/dist/456.js 1.89 kB
packages/apps/esm-offline-tools-app/dist/518.js 2.1 kB
packages/apps/esm-offline-tools-app/dist/534.js 5.46 kB
packages/apps/esm-offline-tools-app/dist/541.js 379 B
packages/apps/esm-offline-tools-app/dist/574.js 996 B
packages/apps/esm-offline-tools-app/dist/58.js 1.99 kB
packages/apps/esm-offline-tools-app/dist/733.js 285 B
packages/apps/esm-offline-tools-app/dist/735.js 2.63 kB
packages/apps/esm-offline-tools-app/dist/740.js 4.57 kB
packages/apps/esm-offline-tools-app/dist/759.js 16.5 kB
packages/apps/esm-offline-tools-app/dist/788.js 42.9 kB
packages/apps/esm-offline-tools-app/dist/889.js 109 kB
packages/apps/esm-offline-tools-app/dist/925.js 6.66 kB
packages/apps/esm-offline-tools-app/dist/967.js 489 B
packages/apps/esm-offline-tools-app/dist/996.js 5.88 kB
packages/apps/esm-offline-tools-app/dist/main.js 52.3 kB
packages/apps/esm-offline-tools-app/dist/openmrs-esm-offline-tools-app.js 3.26 kB
packages/apps/esm-primary-navigation-app/dist/146.js 6.72 kB
packages/apps/esm-primary-navigation-app/dist/216.js 544 B
packages/apps/esm-primary-navigation-app/dist/34.js 3.03 kB
packages/apps/esm-primary-navigation-app/dist/414.js 461 B
packages/apps/esm-primary-navigation-app/dist/473.js 1.16 kB
packages/apps/esm-primary-navigation-app/dist/483.js 11.4 kB
packages/apps/esm-primary-navigation-app/dist/574.js 178 B
packages/apps/esm-primary-navigation-app/dist/656.js 5.51 kB
packages/apps/esm-primary-navigation-app/dist/710.js 6.28 kB
packages/apps/esm-primary-navigation-app/dist/723.js 4.52 kB
packages/apps/esm-primary-navigation-app/dist/735.js 2.63 kB
packages/apps/esm-primary-navigation-app/dist/787.js 9.38 kB
packages/apps/esm-primary-navigation-app/dist/788.js 42.9 kB
packages/apps/esm-primary-navigation-app/dist/889.js 109 kB
packages/apps/esm-primary-navigation-app/dist/98.js 2.2 kB
packages/apps/esm-primary-navigation-app/dist/main.js 9.39 kB
packages/apps/esm-primary-navigation-app/dist/openmrs-esm-primary-navigation-app.js 3.28 kB
packages/framework/esm-api/dist/openmrs-esm-api.js 9.49 kB
packages/framework/esm-breadcrumbs/dist/openmrs-esm-breadcrumbs.js 3.24 kB
packages/framework/esm-config/dist/openmrs-esm-module-config.js 7.87 kB
packages/framework/esm-error-handling/dist/openmrs-esm-error-handling.js 1.41 kB
packages/framework/esm-extensions/dist/openmrs-esm-extensions.js 8.45 kB
packages/framework/esm-framework/dist/openmrs-esm-framework.js 202 kB
packages/framework/esm-globals/dist/openmrs-esm-globals.js 1.59 kB
packages/framework/esm-offline/dist/openmrs-esm-offline.js 35 kB
packages/framework/esm-react-utils/dist/openmrs-esm-react-utils.js 18.2 kB
packages/framework/esm-state/dist/openmrs-esm-state.js 1.47 kB
packages/framework/esm-styleguide/dist/openmrs-esm-styleguide.js 19 kB
packages/framework/esm-utils/dist/openmrs-esm-utils.js 10.8 kB
packages/shell/esm-app-shell/dist/c528bbcc76073b276b49.js 923 B
packages/shell/esm-app-shell/dist/openmrs.js 350 kB
packages/shell/esm-app-shell/dist/service-worker.js 51.1 kB
packages/tooling/openmrs/dist/cli.js 2.86 kB
packages/tooling/openmrs/dist/commands/assemble.js 2.32 kB
packages/tooling/openmrs/dist/commands/build.js 2.26 kB
packages/tooling/openmrs/dist/commands/debug.js 539 B
packages/tooling/openmrs/dist/commands/develop.js 1.66 kB
packages/tooling/openmrs/dist/commands/index.js 360 B
packages/tooling/openmrs/dist/commands/start.js 848 B
packages/tooling/openmrs/dist/index.js 445 B
packages/tooling/openmrs/dist/runner.js 799 B
packages/tooling/openmrs/dist/utils/config.js 639 B
packages/tooling/openmrs/dist/utils/debugger.js 529 B
packages/tooling/openmrs/dist/utils/dependencies.js 300 B
packages/tooling/openmrs/dist/utils/helpers.js 275 B
packages/tooling/openmrs/dist/utils/importmap.js 2.79 kB
packages/tooling/openmrs/dist/utils/index.js 370 B
packages/tooling/openmrs/dist/utils/logger.js 234 B
packages/tooling/openmrs/dist/utils/untar.js 648 B
packages/tooling/openmrs/dist/utils/variables.js 192 B
packages/tooling/openmrs/dist/utils/webpack.js 276 B
packages/tooling/webpack-config/dist/index.js 3.01 kB
packages/tooling/webpack-config/dist/optimize.js 1.79 kB

compressed-size-action

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Ian!

@denniskigen denniskigen merged commit db74e31 into main Feb 2, 2023
@denniskigen denniskigen deleted the docs/fix-broken-importmap-link branch February 2, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants