(feat) Even more left nav UI tweaks #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -64 B (0%) Total Size: 2.19 MB ℹ️ View Unchanged
|
vasharma05
approved these changes
Mar 16, 2023
| /* Tablet */ | ||
| :global(.omrs-breakpoint-lt-desktop) { | ||
| :global(.cds--side-nav__link) { | ||
| height: 3rem; |
There was a problem hiding this comment.
I believe this should be taken by the size prop of the menu item instead of CSS, creates confusion when making changes in the component. Faced it when working with tables too.
There was a problem hiding this comment.
I don't see a size prop https://react.carbondesignsystem.com/?path=/docs/components-ui-shell--fixed-side-nav.
There was a problem hiding this comment.
Although, there is a large prop on side nav links which applies the .#{$prefix}--side-nav__item--large class which defaults to 3rem.
There was a problem hiding this comment.
Don't see it in the docs. Mind dropping a link, Ian?
There was a problem hiding this comment.
Never mind, just seen it
There was a problem hiding this comment.
The SideNavLink component in the docs you shared. The class I was referring to is defined here
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
Annoying that we're here again, but I cannot for the life of me figure out why local changes to the styleguide don't get propagated to my dev server after rebuilding the styleguide when running
yarn run:shell. Regardless, here we are. The basic premise here is that these changes:#f4f4f4) on focus and hover.#161616, whereas inactive items have a text color of#525252.3remtall on a tablet, and2remtall on a desktop.Other
This is the desired outcome.