(feat) Load scripts for non-visible modules asynchronously after starting application #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
reviewed
Jun 26, 2023
denniskigen
reviewed
Jun 26, 2023
| const module = factory(); | ||
|
|
||
| if (!(typeof module === "object") || module === null) { | ||
| const error = `Container for ${jsPackage} did not return an ESM module as expected`; |
There was a problem hiding this comment.
Suggested change
| const error = `Container for ${jsPackage} did not return an ESM module as expected`; | |
| const error = `Container for ${jsPackage} did not return an ES module as expected`; |
There was a problem hiding this comment.
ES = "ECMAScript" (the semi-official name of Javascript)
ESM = "ECMAScript Module"
Hence
"ES module" == "ESM"
|
Size Change: +1.74 kB (0%) Total Size: 2.26 MB
ℹ️ View Unchanged
|
denniskigen
reviewed
Jun 26, 2023
Co-authored-by: Dennis Kigen <kigen.work@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
This is something I was deferring to "phase 2" because it was a little hard to test without the full routes setup. The idea here is that we pre-load the script (and the initial chunk containing the contents of
index.ts), but not call any code at this point.Hopefully, this should make things feel more responsive.
NB It is quite trivial for this design to be less than optimal; however, further optimising this likely involves prioritising the preloading (i.e., ensure that scripts are preloaded in the order they are likely needed, but that requires some way of declaring that prioritisation).
Screenshots
Related Issue
Other