Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KH-239: Translate login page to km #716

Merged
merged 6 commits into from
Jul 3, 2023
Merged

KH-239: Translate login page to km #716

merged 6 commits into from
Jul 3, 2023

Conversation

kdaud
Copy link
Member

@kdaud kdaud commented Jun 28, 2023

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Screenshots

Related Issue

https://mekomsolutions.atlassian.net/browse/KH-239

Other

vasharma05
vasharma05 reviewed Jun 28, 2023
View reviewed changes
Copy link
Member

@vasharma05 vasharma05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these all the required translations?
Please compare it with en.json

@kdaud
Copy link
Member Author

kdaud commented Jun 28, 2023 •
edited
Loading

@vasharma05, I've crosschecked and found a few other translation applicable to km login page. I will have to update this PR once I get them!

@rbuisson
Copy link
Contributor

@kdaud , could you maybe set the PR as draft until it's complete?

@kdaud kdaud marked this pull request as draft June 28, 2023 15:59
@kdaud kdaud changed the title KH-239: Translate login page to khmer KH-239: Translate login page to km Jun 29, 2023
@kdaud kdaud marked this pull request as ready for review June 30, 2023 10:23
@kdaud kdaud force-pushed the KH-239 branch 2 times, most recently from 97f87ef to 3703940 Compare June 30, 2023 10:37
@kdaud kdaud marked this pull request as draft June 30, 2023 10:44
@kdaud kdaud marked this pull request as ready for review July 2, 2023 01:57
@kdaud kdaud requested a review from vasharma05 July 2, 2023 02:03
vasharma05
vasharma05 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@vasharma05 vasharma05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks

@vasharma05 vasharma05 merged commit 0b51bdf into openmrs:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasharma05 vasharma05 vasharma05 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdaud @rbuisson @vasharma05