(feat) O3-2258: Extension system support for feature flags #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandones
commented
Jul 15, 2023
| * @returns A list of extensions that should be rendered | ||
| */ | ||
| export function getConnectedExtensions( | ||
| assignedExtensions: Array<AssignedExtension>, | ||
| online: boolean | null = null | ||
| online: boolean | null = null, | ||
| enabledFeatureFlags: Array<string> | null = null |
There was a problem hiding this comment.
I wasn't sure whether the featureFlag check should happen in the step where we determine assigned extensions or connected extensions. But if I had done it in the assigned extensions phase, I'd have needed to create a subscription on the feature flags store which updated the extension output store. I opted for the less complex option, which unfortunately creates a bit of ambiguity around the meaning of the word "connected."
There was a problem hiding this comment.
At some point, we should probably look into refactoring these anyways (I've never been a big fan of having hooks explicitly named after "connection status" rather than, say, some sort of lifecycle phase).
|
Size Change: +2.55 kB (0%) Total Size: 2.27 MB
ℹ️ View Unchanged
|
|
Build failing and I can't repro locally. Good luck to me. |
|
This is ready for review @ibacher @denniskigen |
ibacher
changed the title
ibacher
approved these changes
Jul 18, 2023
| * @returns A list of extensions that should be rendered | ||
| */ | ||
| export function getConnectedExtensions( | ||
| assignedExtensions: Array<AssignedExtension>, | ||
| online: boolean | null = null | ||
| online: boolean | null = null, | ||
| enabledFeatureFlags: Array<string> | null = null |
There was a problem hiding this comment.
At some point, we should probably look into refactoring these anyways (I've never been a big fan of having hooks explicitly named after "connection status" rather than, say, some sort of lifecycle phase).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
This makes it so you can add
featureFlag: "xyz"to an extension registration in a routes file, and then that extension will be togglable using the feature flag.Related Issue
https://issues.openmrs.org/browse/O3-2258