-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Add support for hashed routes #736
Conversation
Size Change: -210 kB (-8%) ✅ Total Size: 2.27 MB
ℹ️ View Unchanged
|
I looked at it and didn't really understand what it's about. |
@brandones That's fair. This is really all about caching. Earlier this year, I made some changes to allow implementations to more aggressively cache the frontend files, specifically by adding a content hash to As part of V5 which added the routes.json, I added a provision that if we were generating a content hash for the importmap, we generate a content hash for the routes.registry.json file as well; however I forgot to add the part to the |
Requirements
For changes to apps
If applicable
Summary
If the
--hash-importmap
flag is used in the assemble command, we also hash theroutes.registry.json
, since these are basically generated as linked artefacts. However, I did not update the build command to find the hashedroutes.regsitry.json
file the same way it finds the hashedimportmap.json
. This PR fixes that oversight so that the--hash-importmap
option will work as expected.Screenshots
Related Issue
Other