O3-2407: App Menu and User Menu should hide if their panel has no con… #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogoodrich
commented
Sep 11, 2023
| @@ -33,11 +33,12 @@ const Navbar: React.FC = () => { | |||
| const [activeHeaderPanel, setActiveHeaderPanel] = useState<string>(null); | |||
| const allowedLocales = session?.allowedLocales ?? null; | |||
| const layout = useLayoutType(); | |||
| const navMenuItems = useAssignedExtensions( | |||
| const navMenuItems = useConnectedExtensions( | |||
There was a problem hiding this comment.
this is tangential, but it looks like useConnectedExtensions is now preferred over useAssignedExtensions because it takes into account how feature toggles and offline/online affects what extensions are available?
There was a problem hiding this comment.
Yeah. At some point we should probably remove this distinction.
|
Size Change: +43 B (0%) Total Size: 2.81 MB ℹ️ View Unchanged
|
|
i will have to dig in and see why the compile is failing... it appears to work for me when I test locally, have to dive in deeper to see what is different. |
|
Okay, this was my bad, can reproduce locally now |
ibacher
approved these changes
Sep 12, 2023
…tents (fix tests)
|
Fixed the test error in a follow-on commit. |
|
Thanks @denniskigen and @ibacher , merging! |
denniskigen
reviewed
Sep 12, 2023
| useSession, | ||
| useConfig, | ||
| useConnectedExtensions, | ||
| useConfig |
There was a problem hiding this comment.
Missing trailing comma here, I think.
There was a problem hiding this comment.
Oops, thanks @denniskigen ... that's what I get for trying to merge directly within github :) fixing now...
…tents (fix tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://issues.openmrs.org/browse/O3-2407