(feat) Dynamically reload routes.json files for packages from sources #824

ibacher · 2023-11-28T20:35:15Z

Requirements

This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.

For changes to apps

My work conforms to the OpenMRS 3.0 Styleguide and design documentation.

If applicable

My work includes tests or is validated by existing tests.
I have updated the esm-framework mock to reflect any API changes I have made.

Summary

This is sort of a follow-on from #816, though completely independent of that PR and implements a feature discussed here. Specifically, if you use the openmrs develop CLI option (which is usually aliased as yarn start in our projects), changes to the routes.json file for any watched projects will be reflected after the Webpack reload cycle completes.

Basically, this means that you should see any changes to routes.json reflected the same way changes to any other source file are.

Screenshots

Related Issue

Other

github-actions · 2023-11-28T20:39:40Z

Size Change: +834 B (0%)

Total Size: 2.72 MB

ℹ️ View Unchanged

Filename	Size	Change
`packages/apps/esm-devtools-app/dist/630.js`	2.69 kB	0 B
`packages/apps/esm-devtools-app/dist/729.js`	6.79 kB	0 B
`packages/apps/esm-devtools-app/dist/735.js`	2.63 kB	0 B
`packages/apps/esm-devtools-app/dist/788.js`	42.9 kB	0 B
`packages/apps/esm-devtools-app/dist/875.js`	9.76 kB	0 B
`packages/apps/esm-devtools-app/dist/889.js`	109 kB	0 B
`packages/apps/esm-devtools-app/dist/961.js`	25.3 kB	0 B
`packages/apps/esm-devtools-app/dist/988.js`	328 B	0 B
`packages/apps/esm-devtools-app/dist/main.js`	3.14 kB	0 B
`packages/apps/esm-devtools-app/dist/openmrs-esm-devtools-app.js`	3.18 kB	0 B
`packages/apps/esm-implementer-tools-app/dist/319.js`	633 B	0 B
`packages/apps/esm-implementer-tools-app/dist/426.js`	1.66 kB	0 B
`packages/apps/esm-implementer-tools-app/dist/460.js`	735 B	0 B
`packages/apps/esm-implementer-tools-app/dist/56.js`	3.07 kB	0 B
`packages/apps/esm-implementer-tools-app/dist/560.js`	9.61 kB	0 B
`packages/apps/esm-implementer-tools-app/dist/574.js`	560 B	0 B
`packages/apps/esm-implementer-tools-app/dist/587.js`	2.92 kB	0 B
`packages/apps/esm-implementer-tools-app/dist/620.js`	126 kB	0 B
`packages/apps/esm-implementer-tools-app/dist/625.js`	562 B	0 B
`packages/apps/esm-implementer-tools-app/dist/651.js`	6.86 kB	0 B
`packages/apps/esm-implementer-tools-app/dist/727.js`	33 kB	0 B
`packages/apps/esm-implementer-tools-app/dist/735.js`	2.63 kB	0 B
`packages/apps/esm-implementer-tools-app/dist/738.js`	6.79 kB	0 B
`packages/apps/esm-implementer-tools-app/dist/757.js`	560 B	0 B
`packages/apps/esm-implementer-tools-app/dist/767.js`	10.4 kB	0 B
`packages/apps/esm-implementer-tools-app/dist/788.js`	42.9 kB	0 B
`packages/apps/esm-implementer-tools-app/dist/807.js`	559 B	0 B
`packages/apps/esm-implementer-tools-app/dist/833.js`	681 B	0 B
`packages/apps/esm-implementer-tools-app/dist/889.js`	109 kB	0 B
`packages/apps/esm-implementer-tools-app/dist/913.js`	61.2 kB	0 B
`packages/apps/esm-implementer-tools-app/dist/main.js`	73.3 kB	0 B
`packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js`	3.3 kB	0 B
`packages/apps/esm-login-app/dist/111.js`	1.22 kB	0 B
`packages/apps/esm-login-app/dist/126.js`	2.5 kB	0 B
`packages/apps/esm-login-app/dist/173.js`	1.22 kB	0 B
`packages/apps/esm-login-app/dist/224.js`	256 B	0 B
`packages/apps/esm-login-app/dist/236.js`	272 B	0 B
`packages/apps/esm-login-app/dist/240.js`	364 B	0 B
`packages/apps/esm-login-app/dist/272.js`	264 B	0 B
`packages/apps/esm-login-app/dist/319.js`	692 B	0 B
`packages/apps/esm-login-app/dist/336.js`	234 B	0 B
`packages/apps/esm-login-app/dist/370.js`	30.6 kB	0 B
`packages/apps/esm-login-app/dist/460.js`	782 B	0 B
`packages/apps/esm-login-app/dist/539.js`	298 B	0 B
`packages/apps/esm-login-app/dist/56.js`	3.06 kB	0 B
`packages/apps/esm-login-app/dist/574.js`	609 B	0 B
`packages/apps/esm-login-app/dist/625.js`	600 B	0 B
`packages/apps/esm-login-app/dist/627.js`	257 B	0 B
`packages/apps/esm-login-app/dist/63.js`	16.5 kB	0 B
`packages/apps/esm-login-app/dist/644.js`	305 B	0 B
`packages/apps/esm-login-app/dist/673.js`	284 B	0 B
`packages/apps/esm-login-app/dist/729.js`	6.78 kB	0 B
`packages/apps/esm-login-app/dist/735.js`	2.63 kB	0 B
`packages/apps/esm-login-app/dist/757.js`	698 B	0 B
`packages/apps/esm-login-app/dist/788.js`	42.9 kB	0 B
`packages/apps/esm-login-app/dist/807.js`	961 B	0 B
`packages/apps/esm-login-app/dist/812.js`	22.5 kB	0 B
`packages/apps/esm-login-app/dist/833.js`	727 B	0 B
`packages/apps/esm-login-app/dist/889.js`	109 kB	0 B
`packages/apps/esm-login-app/dist/main.js`	57 kB	0 B
`packages/apps/esm-login-app/dist/openmrs-esm-login-app.js`	3.32 kB	0 B
`packages/apps/esm-offline-tools-app/dist/102.js`	81.3 kB	0 B
`packages/apps/esm-offline-tools-app/dist/193.js`	55 kB	0 B
`packages/apps/esm-offline-tools-app/dist/319.js`	1.14 kB	0 B
`packages/apps/esm-offline-tools-app/dist/460.js`	1.32 kB	0 B
`packages/apps/esm-offline-tools-app/dist/56.js`	3.07 kB	0 B
`packages/apps/esm-offline-tools-app/dist/574.js`	1.04 kB	0 B
`packages/apps/esm-offline-tools-app/dist/625.js`	1.04 kB	0 B
`packages/apps/esm-offline-tools-app/dist/63.js`	16.5 kB	0 B
`packages/apps/esm-offline-tools-app/dist/729.js`	6.79 kB	0 B
`packages/apps/esm-offline-tools-app/dist/735.js`	2.63 kB	0 B
`packages/apps/esm-offline-tools-app/dist/757.js`	1.2 kB	0 B
`packages/apps/esm-offline-tools-app/dist/788.js`	42.9 kB	0 B
`packages/apps/esm-offline-tools-app/dist/807.js`	1.1 kB	0 B
`packages/apps/esm-offline-tools-app/dist/833.js`	1.22 kB	0 B
`packages/apps/esm-offline-tools-app/dist/889.js`	109 kB	0 B
`packages/apps/esm-offline-tools-app/dist/main.js`	136 kB	0 B
`packages/apps/esm-offline-tools-app/dist/openmrs-esm-offline-tools-app.js`	3.29 kB	0 B
`packages/apps/esm-primary-navigation-app/dist/262.js`	13.3 kB	0 B
`packages/apps/esm-primary-navigation-app/dist/319.js`	200 B	0 B
`packages/apps/esm-primary-navigation-app/dist/460.js`	217 B	0 B
`packages/apps/esm-primary-navigation-app/dist/574.js`	183 B	0 B
`packages/apps/esm-primary-navigation-app/dist/625.js`	184 B	0 B
`packages/apps/esm-primary-navigation-app/dist/63.js`	16.5 kB	0 B
`packages/apps/esm-primary-navigation-app/dist/729.js`	6.79 kB	0 B
`packages/apps/esm-primary-navigation-app/dist/735.js`	18.7 kB	0 B
`packages/apps/esm-primary-navigation-app/dist/757.js`	209 B	0 B
`packages/apps/esm-primary-navigation-app/dist/788.js`	42.9 kB	0 B
`packages/apps/esm-primary-navigation-app/dist/807.js`	235 B	0 B
`packages/apps/esm-primary-navigation-app/dist/833.js`	210 B	0 B
`packages/apps/esm-primary-navigation-app/dist/889.js`	109 kB	0 B
`packages/apps/esm-primary-navigation-app/dist/960.js`	2.64 kB	0 B
`packages/apps/esm-primary-navigation-app/dist/main.js`	33.7 kB	0 B
`packages/apps/esm-primary-navigation-app/dist/openmrs-esm-primary-navigation-app.js`	3.23 kB	0 B
`packages/framework/esm-api/dist/openmrs-esm-api.js`	10 kB	0 B
`packages/framework/esm-breadcrumbs/dist/openmrs-esm-breadcrumbs.js`	2.66 kB	0 B
`packages/framework/esm-config/dist/openmrs-esm-module-config.js`	7.87 kB	0 B
`packages/framework/esm-dynamic-loading/dist/openmrs-esm-dynamic-loading.js`	2.12 kB	0 B
`packages/framework/esm-error-handling/dist/openmrs-esm-error-handling.js`	894 B	0 B
`packages/framework/esm-extensions/dist/openmrs-esm-extensions.js`	8.05 kB	0 B
`packages/framework/esm-feature-flags/dist/openmrs-esm-feature-flags.js`	1.67 kB	0 B
`packages/framework/esm-framework/dist/455.openmrs-esm-framework.js`	4.57 kB	0 B
`packages/framework/esm-framework/dist/530.openmrs-esm-framework.js`	2.92 kB	0 B
`packages/framework/esm-framework/dist/645.openmrs-esm-framework.js`	9.31 kB	0 B
`packages/framework/esm-framework/dist/655.openmrs-esm-framework.js`	6.83 kB	0 B
`packages/framework/esm-framework/dist/710.openmrs-esm-framework.js`	6.48 kB	0 B
`packages/framework/esm-framework/dist/735.openmrs-esm-framework.js`	2.66 kB	0 B
`packages/framework/esm-framework/dist/788.openmrs-esm-framework.js`	42.9 kB	0 B
`packages/framework/esm-framework/dist/openmrs-esm-framework.js`	376 kB	0 B
`packages/framework/esm-globals/dist/openmrs-esm-globals.js`	756 B	0 B
`packages/framework/esm-offline/dist/openmrs-esm-offline.js`	34.4 kB	0 B
`packages/framework/esm-react-utils/dist/openmrs-esm-react-utils.js`	15.4 kB	0 B
`packages/framework/esm-routes/dist/openmrs-esm-utils.js`	1.46 kB	0 B
`packages/framework/esm-state/dist/openmrs-esm-state.js`	888 B	0 B
`packages/framework/esm-styleguide/dist/openmrs-esm-styleguide.js`	19.3 kB	0 B
`packages/framework/esm-utils/dist/openmrs-esm-utils.js`	11.2 kB	0 B
`packages/shell/esm-app-shell/dist/08a99d285a4ddb28.js`	6.45 kB	0 B
`packages/shell/esm-app-shell/dist/695f23c4e6b3f009.js`	1.58 kB	0 B
`packages/shell/esm-app-shell/dist/b66a463116735f62.js`	3.81 kB	0 B
`packages/shell/esm-app-shell/dist/openmrs.a6ed252f12af37c9.js`	334 kB	0 B
`packages/shell/esm-app-shell/dist/service-worker.js`	60.5 kB	0 B
`packages/tooling/openmrs/dist/cli.js`	2.85 kB	-5 B (0%)
`packages/tooling/openmrs/dist/commands/assemble.js`	2.4 kB	0 B
`packages/tooling/openmrs/dist/commands/build.js`	1.34 kB	0 B
`packages/tooling/openmrs/dist/commands/debug.js`	545 B	0 B
`packages/tooling/openmrs/dist/commands/develop.js`	2.59 kB	+733 B (+39%)	🚨
`packages/tooling/openmrs/dist/commands/index.js`	438 B	0 B
`packages/tooling/openmrs/dist/commands/start.js`	851 B	0 B
`packages/tooling/openmrs/dist/index.js`	517 B	0 B
`packages/tooling/openmrs/dist/runner.js`	637 B	0 B
`packages/tooling/openmrs/dist/utils/config.js`	728 B	0 B
`packages/tooling/openmrs/dist/utils/debugger.js`	576 B	+48 B (+9%)	🔍
`packages/tooling/openmrs/dist/utils/dependencies.js`	648 B	+8 B (+1%)
`packages/tooling/openmrs/dist/utils/helpers.js`	395 B	0 B
`packages/tooling/openmrs/dist/utils/importmap.js`	3.07 kB	+50 B (+2%)
`packages/tooling/openmrs/dist/utils/index.js`	444 B	0 B
`packages/tooling/openmrs/dist/utils/logger.js`	368 B	0 B
`packages/tooling/openmrs/dist/utils/npmConfig.js`	830 B	0 B
`packages/tooling/openmrs/dist/utils/untar.js`	722 B	0 B
`packages/tooling/openmrs/dist/utils/variables.js`	192 B	0 B
`packages/tooling/openmrs/dist/utils/webpack.js`	278 B	0 B
`packages/tooling/webpack-config/dist/index.js`	3.58 kB	0 B

_{compressed-size-action}

…eload

brandones

LGTM

(feat) Dynamically reload routes.json files for packages from sources

1bacc58

ibacher requested a review from denniskigen November 28, 2023 20:35

ibacher added 2 commits November 29, 2023 11:58

Remove unnecessary wait

603a553

Merge remote-tracking branch 'origin/main' into feat/dynamic-routes-r…

ac5d26d

…eload

ibacher force-pushed the feat/dynamic-routes-reload branch from b25c3d1 to ac5d26d Compare December 15, 2023 18:09

Merge remote-tracking branch 'origin/main' into feat/dynamic-routes-r…

0390e67

…eload

brandones approved these changes Dec 30, 2023

View reviewed changes

brandones added 2 commits December 30, 2023 13:25

Remove import type annotations

eb0dd68

Fixup lint

f95171e

brandones merged commit 85301d8 into main Dec 30, 2023
8 of 9 checks passed

brandones deleted the feat/dynamic-routes-reload branch December 30, 2023 13:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(feat) Dynamically reload routes.json files for packages from sources #824

(feat) Dynamically reload routes.json files for packages from sources #824

ibacher commented Nov 28, 2023

github-actions bot commented Nov 28, 2023 •

edited

Loading

brandones left a comment

(feat) Dynamically reload routes.json files for packages from sources #824

(feat) Dynamically reload routes.json files for packages from sources #824

Conversation

ibacher commented Nov 28, 2023

Requirements

For changes to apps

If applicable

Summary

Screenshots

Related Issue

Other

github-actions bot commented Nov 28, 2023 • edited Loading

brandones left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 28, 2023 •

edited

Loading