Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Restore top nav margin to render offline banner #856

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

icrc-jofrancisco
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

This pull request addresses the issue where the offline banner overlaps with the top nav header due to the removal of the "margin".

The class already existed but was removed by mistake when some changes were made to this component.

Screenshots

Before:
image

After:
image

Related Issue

Other

Thanks,
CC: @ibacher

@ibacher ibacher merged commit b2bae21 into openmrs:main Feb 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants