Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) O3-2935: Trigger E2E tests when there is a change in package.json #951

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

kdaud
Copy link
Member

@kdaud kdaud commented Mar 6, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Refer to this convo: https://openmrs.slack.com/archives/CHP5QAE5R/p1709730208547039

Screenshots

Related Issue

https://issues.openmrs.org/browse/O3-2935

Other

@kdaud kdaud changed the title O3-2935: Trigger E2E tests when there is a change in package.json (fix) O3-2935: Trigger E2E tests when there is a change in package.json Mar 6, 2024
@kdaud kdaud marked this pull request as ready for review March 6, 2024 14:56
@kdaud kdaud changed the title (fix) O3-2935: Trigger E2E tests when there is a change in package.json (fix) O3-2935: Trigger E2E tests when there is any changes in package.json Mar 6, 2024
@kdaud
Copy link
Member Author

kdaud commented Mar 6, 2024

@denniskigen @jayasanka-sack @ibacher could you review this PR? Thanks!

@kdaud kdaud changed the title (fix) O3-2935: Trigger E2E tests when there is any changes in package.json (fix) O3-2935: Trigger E2E tests when there is a change in package.json Mar 6, 2024
Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kdaud !

@jayasanka-sack jayasanka-sack changed the title (fix) O3-2935: Trigger E2E tests when there is a change in package.json (chore) O3-2935: Trigger E2E tests when there is a change in package.json Mar 13, 2024
@jayasanka-sack jayasanka-sack merged commit 923761f into openmrs:main Mar 13, 2024
8 checks passed
@jayasanka-sack
Copy link
Member

@kdaud Can you update other repos too?

@kdaud
Copy link
Member Author

kdaud commented Mar 13, 2024

@jayasanka-sack I've not seen the rule applied elsewhere except on core. Are you suggesting to apply the rule on other esm repos having E2E tests?

@jayasanka-sack
Copy link
Member

I see. We might not need to have it on other repos, as they don't come with toolings like the core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants