-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Fix spacing around address empty state in patient banner #955
Conversation
Size Change: -366 kB (-11%) 👏 Total Size: 3.09 MB
ℹ️ View Unchanged
|
ba66283
to
9695391
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @brandones. What's the plan with esm-patient-banner-app in the Patient Chart?
Eventually I'd like to just have a patient banner component in styleguide that does the same thing as the patient-banner extension. Then we can delete esm-patient-banner-app from the RefApp. Distros should switch over to using the styleguide component, but can continue including esm-patient-banner-app as long as they need to, though we will no longer be maintaining it. |
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
Redoing openmrs/openmrs-esm-patient-chart#1729 because the banner lives here now