(feat) O3-1426: Modals should not be extensions

[brandones]

Requirements

• This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

• My work conforms to the O3 Styleguide and design documentation.

If applicable

• My work includes tests or is validated by existing tests.
• I have updated the esm-framework mock to reflect any API changes I have made.

Summary

This creates a new "modal system" specifically for modals. Apps should move modals out of the "extensions" section of routes.json and into the "modals" section. The modals system is much simpler than the extension system. Modals defined as extensions are supported for backwards compatibility, but a console warning is logged.

There should be no UI change associated with this change.

Screenshots

modals.mp4

Related Issue

https://issues.openmrs.org/browse/O3-1426

Other

Requires routes JSON Schema update. PR: openmrs/openmrs-contrib-json-schemas#6

[github-actions]

Size Change: -330 kB (-9%) ✅

Total Size: 3.21 MB

Filename	Size	Change
packages/shell/esm-app-shell/dist/openmrs.08ee82e5194e661c.js	0 B	-367 kB (removed)	🏆

ℹ️ View Unchanged

Filename	Size	Change
packages/apps/esm-devtools-app/dist/630.js	2.69 kB	0 B
packages/apps/esm-devtools-app/dist/667.js	6.96 kB	0 B
packages/apps/esm-devtools-app/dist/735.js	2.63 kB	0 B
packages/apps/esm-devtools-app/dist/788.js	42.9 kB	0 B
packages/apps/esm-devtools-app/dist/875.js	9.76 kB	0 B
packages/apps/esm-devtools-app/dist/884.js	15.2 kB	0 B
packages/apps/esm-devtools-app/dist/889.js	155 kB	+6.99 kB (+5%)	🔍
packages/apps/esm-devtools-app/dist/961.js	25.3 kB	0 B
packages/apps/esm-devtools-app/dist/988.js	328 B	0 B
packages/apps/esm-devtools-app/dist/main.js	3.14 kB	0 B
packages/apps/esm-devtools-app/dist/openmrs-esm-devtools-app.js	3.19 kB	0 B
packages/apps/esm-implementer-tools-app/dist/271.js	716 B	0 B
packages/apps/esm-implementer-tools-app/dist/319.js	633 B	0 B
packages/apps/esm-implementer-tools-app/dist/426.js	1.67 kB	0 B
packages/apps/esm-implementer-tools-app/dist/460.js	735 B	0 B
packages/apps/esm-implementer-tools-app/dist/482.js	15.2 kB	0 B
packages/apps/esm-implementer-tools-app/dist/56.js	3.07 kB	0 B
packages/apps/esm-implementer-tools-app/dist/560.js	9.63 kB	0 B
packages/apps/esm-implementer-tools-app/dist/574.js	560 B	0 B
packages/apps/esm-implementer-tools-app/dist/587.js	2.92 kB	0 B
packages/apps/esm-implementer-tools-app/dist/620.js	126 kB	0 B
packages/apps/esm-implementer-tools-app/dist/625.js	562 B	0 B
packages/apps/esm-implementer-tools-app/dist/644.js	717 B	0 B
packages/apps/esm-implementer-tools-app/dist/657.js	7.01 kB	0 B
packages/apps/esm-implementer-tools-app/dist/71.js	6.97 kB	0 B
packages/apps/esm-implementer-tools-app/dist/72.js	61.2 kB	0 B
packages/apps/esm-implementer-tools-app/dist/727.js	33.1 kB	0 B
packages/apps/esm-implementer-tools-app/dist/735.js	2.63 kB	0 B
packages/apps/esm-implementer-tools-app/dist/757.js	560 B	0 B
packages/apps/esm-implementer-tools-app/dist/767.js	10.4 kB	0 B
packages/apps/esm-implementer-tools-app/dist/788.js	42.9 kB	0 B
packages/apps/esm-implementer-tools-app/dist/791.js	284 B	0 B
packages/apps/esm-implementer-tools-app/dist/807.js	559 B	0 B
packages/apps/esm-implementer-tools-app/dist/833.js	681 B	0 B
packages/apps/esm-implementer-tools-app/dist/889.js	155 kB	+6.99 kB (+5%)	🔍
packages/apps/esm-implementer-tools-app/dist/main.js	73.3 kB	0 B
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js	3.31 kB	0 B
packages/apps/esm-login-app/dist/111.js	1.22 kB	0 B
packages/apps/esm-login-app/dist/126.js	2.5 kB	0 B
packages/apps/esm-login-app/dist/173.js	1.22 kB	0 B
packages/apps/esm-login-app/dist/224.js	256 B	0 B
packages/apps/esm-login-app/dist/236.js	272 B	0 B
packages/apps/esm-login-app/dist/240.js	364 B	0 B
packages/apps/esm-login-app/dist/271.js	734 B	0 B
packages/apps/esm-login-app/dist/272.js	264 B	0 B
packages/apps/esm-login-app/dist/319.js	675 B	0 B
packages/apps/esm-login-app/dist/336.js	234 B	0 B
packages/apps/esm-login-app/dist/363.js	30.1 kB	0 B
packages/apps/esm-login-app/dist/460.js	757 B	0 B
packages/apps/esm-login-app/dist/539.js	298 B	0 B
packages/apps/esm-login-app/dist/56.js	3.06 kB	0 B
packages/apps/esm-login-app/dist/574.js	577 B	0 B
packages/apps/esm-login-app/dist/625.js	590 B	0 B
packages/apps/esm-login-app/dist/627.js	257 B	0 B
packages/apps/esm-login-app/dist/63.js	16.5 kB	0 B
packages/apps/esm-login-app/dist/644.js	733 B	0 B
packages/apps/esm-login-app/dist/667.js	6.96 kB	0 B
packages/apps/esm-login-app/dist/673.js	284 B	0 B
packages/apps/esm-login-app/dist/735.js	2.63 kB	0 B
packages/apps/esm-login-app/dist/757.js	676 B	0 B
packages/apps/esm-login-app/dist/788.js	42.9 kB	0 B
packages/apps/esm-login-app/dist/807.js	921 B	0 B
packages/apps/esm-login-app/dist/833.js	702 B	0 B
packages/apps/esm-login-app/dist/836.js	22.5 kB	0 B
packages/apps/esm-login-app/dist/884.js	15.2 kB	0 B
packages/apps/esm-login-app/dist/889.js	155 kB	+6.99 kB (+5%)	🔍
packages/apps/esm-login-app/dist/main.js	56.6 kB	0 B
packages/apps/esm-login-app/dist/openmrs-esm-login-app.js	3.37 kB	0 B
packages/apps/esm-offline-tools-app/dist/271.js	1.26 kB	0 B
packages/apps/esm-offline-tools-app/dist/319.js	1.23 kB	0 B
packages/apps/esm-offline-tools-app/dist/430.js	55.4 kB	0 B
packages/apps/esm-offline-tools-app/dist/460.js	1.39 kB	0 B
packages/apps/esm-offline-tools-app/dist/56.js	3.07 kB	0 B
packages/apps/esm-offline-tools-app/dist/574.js	1.04 kB	0 B
packages/apps/esm-offline-tools-app/dist/625.js	1.12 kB	0 B
packages/apps/esm-offline-tools-app/dist/63.js	16.5 kB	0 B
packages/apps/esm-offline-tools-app/dist/644.js	1.26 kB	0 B
packages/apps/esm-offline-tools-app/dist/667.js	6.96 kB	0 B
packages/apps/esm-offline-tools-app/dist/735.js	2.63 kB	0 B
packages/apps/esm-offline-tools-app/dist/757.js	1.29 kB	0 B
packages/apps/esm-offline-tools-app/dist/788.js	42.9 kB	0 B
packages/apps/esm-offline-tools-app/dist/807.js	1.19 kB	0 B
packages/apps/esm-offline-tools-app/dist/833.js	1.3 kB	0 B
packages/apps/esm-offline-tools-app/dist/884.js	15.2 kB	0 B
packages/apps/esm-offline-tools-app/dist/889.js	155 kB	+6.99 kB (+5%)	🔍
packages/apps/esm-offline-tools-app/dist/922.js	81.2 kB	0 B
packages/apps/esm-offline-tools-app/dist/main.js	136 kB	0 B
packages/apps/esm-offline-tools-app/dist/openmrs-esm-offline-tools-app.js	3.29 kB	0 B
packages/apps/esm-primary-navigation-app/dist/271.js	261 B	0 B
packages/apps/esm-primary-navigation-app/dist/319.js	233 B	0 B
packages/apps/esm-primary-navigation-app/dist/460.js	259 B	0 B
packages/apps/esm-primary-navigation-app/dist/574.js	230 B	0 B
packages/apps/esm-primary-navigation-app/dist/625.js	228 B	0 B
packages/apps/esm-primary-navigation-app/dist/63.js	16.5 kB	0 B
packages/apps/esm-primary-navigation-app/dist/644.js	261 B	0 B
packages/apps/esm-primary-navigation-app/dist/667.js	6.97 kB	0 B
packages/apps/esm-primary-navigation-app/dist/735.js	2.64 kB	0 B
packages/apps/esm-primary-navigation-app/dist/757.js	234 B	0 B
packages/apps/esm-primary-navigation-app/dist/762.js	7.48 kB	0 B
packages/apps/esm-primary-navigation-app/dist/780.js	22.3 kB	0 B
packages/apps/esm-primary-navigation-app/dist/788.js	42.9 kB	0 B
packages/apps/esm-primary-navigation-app/dist/807.js	285 B	0 B
packages/apps/esm-primary-navigation-app/dist/833.js	252 B	0 B
packages/apps/esm-primary-navigation-app/dist/884.js	15.2 kB	0 B
packages/apps/esm-primary-navigation-app/dist/889.js	155 kB	+6.99 kB (+5%)	🔍
packages/apps/esm-primary-navigation-app/dist/958.js	22.1 kB	0 B
packages/apps/esm-primary-navigation-app/dist/main.js	45.9 kB	0 B
packages/apps/esm-primary-navigation-app/dist/openmrs-esm-primary-navigation-app.js	3.23 kB	0 B
packages/framework/esm-api/dist/openmrs-esm-api.js	16.2 kB	0 B
packages/framework/esm-config/dist/openmrs-esm-module-config.js	8.02 kB	0 B
packages/framework/esm-dynamic-loading/dist/openmrs-esm-dynamic-loading.js	2.75 kB	0 B
packages/framework/esm-error-handling/dist/openmrs-esm-error-handling.js	889 B	0 B
packages/framework/esm-extensions/dist/openmrs-esm-extensions.js	8.1 kB	0 B
packages/framework/esm-feature-flags/dist/openmrs-esm-feature-flags.js	1.67 kB	0 B
packages/framework/esm-framework/dist/126.openmrs-esm-framework.js	2.47 kB	0 B
packages/framework/esm-framework/dist/278.openmrs-esm-framework.js	14.5 kB	0 B
packages/framework/esm-framework/dist/530.openmrs-esm-framework.js	2.92 kB	0 B
packages/framework/esm-framework/dist/619.openmrs-esm-framework.js	6.49 kB	0 B
packages/framework/esm-framework/dist/645.openmrs-esm-framework.js	9.31 kB	0 B
packages/framework/esm-framework/dist/680.openmrs-esm-framework.js	6.13 kB	0 B
packages/framework/esm-framework/dist/735.openmrs-esm-framework.js	2.66 kB	0 B
packages/framework/esm-framework/dist/788.openmrs-esm-framework.js	42.9 kB	0 B
packages/framework/esm-framework/dist/openmrs-esm-framework.js	442 kB	+278 B (0%)
packages/framework/esm-globals/dist/openmrs-esm-globals.js	770 B	0 B
packages/framework/esm-navigation/dist/openmrs-esm-navigation.js	9.35 kB	0 B
packages/framework/esm-offline/dist/openmrs-esm-offline.js	34.4 kB	0 B
packages/framework/esm-react-utils/dist/openmrs-esm-react-utils.js	15.1 kB	0 B
packages/framework/esm-routes/dist/openmrs-esm-utils.js	1.46 kB	0 B
packages/framework/esm-state/dist/openmrs-esm-state.js	888 B	0 B
packages/framework/esm-styleguide/dist/openmrs-esm-styleguide.js	52.7 kB	+8.41 kB (+19%)	⚠️
packages/framework/esm-translations/dist/openmrs-esm-core-translations.js	1.34 kB	0 B
packages/framework/esm-utils/dist/openmrs-esm-utils.js	11.1 kB	0 B
packages/shell/esm-app-shell/dist/1b2943adae586d6d.js	245 B	0 B
packages/shell/esm-app-shell/dist/29ae62d7dea61f4e.js	239 B	0 B
packages/shell/esm-app-shell/dist/2c566b2eb7d4c244.js	185 B	0 B
packages/shell/esm-app-shell/dist/35d4864a365b247a.js	6.78 kB	0 B
packages/shell/esm-app-shell/dist/36dbff8e7b9a8907.js	241 B	0 B
packages/shell/esm-app-shell/dist/4b4f127f96a81072.js	1.58 kB	0 B
packages/shell/esm-app-shell/dist/72749ca23b74ec13.js	219 B	0 B
packages/shell/esm-app-shell/dist/b0e030cdac260058.js	280 B	0 B
packages/shell/esm-app-shell/dist/b44e488f33333e3e.js	0 B	-6.66 kB (removed)	🏆
packages/shell/esm-app-shell/dist/b66a463116735f62.js	3.81 kB	0 B
packages/shell/esm-app-shell/dist/cd18961c33262d5e.js	213 B	0 B
packages/shell/esm-app-shell/dist/dae6aa8bf297bfda.js	499 B	0 B
packages/shell/esm-app-shell/dist/openmrs.329f8ceb714374dd.js	368 kB	0 B
packages/shell/esm-app-shell/dist/service-worker.js	45.9 kB	+1 B (0%)
packages/tooling/openmrs/dist/cli.js	2.88 kB	0 B
packages/tooling/openmrs/dist/commands/assemble.js	2.82 kB	0 B
packages/tooling/openmrs/dist/commands/build.js	1.34 kB	0 B
packages/tooling/openmrs/dist/commands/debug.js	545 B	0 B
packages/tooling/openmrs/dist/commands/develop.js	2.59 kB	0 B
packages/tooling/openmrs/dist/commands/index.js	438 B	0 B
packages/tooling/openmrs/dist/commands/start.js	851 B	0 B
packages/tooling/openmrs/dist/index.js	517 B	0 B
packages/tooling/openmrs/dist/runner.js	637 B	0 B
packages/tooling/openmrs/dist/utils/config.js	728 B	0 B
packages/tooling/openmrs/dist/utils/debugger.js	576 B	0 B
packages/tooling/openmrs/dist/utils/dependencies.js	648 B	0 B
packages/tooling/openmrs/dist/utils/helpers.js	395 B	0 B
packages/tooling/openmrs/dist/utils/importmap.js	3.07 kB	0 B
packages/tooling/openmrs/dist/utils/index.js	444 B	0 B
packages/tooling/openmrs/dist/utils/logger.js	368 B	0 B
packages/tooling/openmrs/dist/utils/npmConfig.js	830 B	0 B
packages/tooling/openmrs/dist/utils/untar.js	722 B	0 B
packages/tooling/openmrs/dist/utils/variables.js	192 B	0 B
packages/tooling/openmrs/dist/utils/webpack.js	278 B	0 B
packages/tooling/webpack-config/dist/index.js	3.58 kB	0 B

_{compressed-size-action}

[denniskigen]

LGTM. Excellent addition, @brandones!

[ibacher]

Excellent! Thanks @brandones!

[denniskigen]

Could we write up some docs on this to the O3 docs site, @brandones. Also, should the ticket cover all the places that need to be refactored?

[brandones]

Yeah, I will write some docs! About the ticket, sure, fair enough, I can take care of the refactoring. Though it would be a fine beginner ticket if that would be useful.