Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) disappearance of config data on page reload #163

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

kajambiya
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

There was an issue where if a datasource had a config, the config would be loaded fine on page load but if there was any attempt to reload the component, the config value would disappear. This PR fixes the issue

Screenshots

Related Issue

Other

Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kajambiya

@pirupius pirupius merged commit 881309c into openmrs:main Jan 10, 2024
5 checks passed
@kajambiya
Copy link
Collaborator Author

@dkayiwa
Copy link
Member

dkayiwa commented Jan 29, 2024

@dkayiwa really?

At lease devs are tagging you. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants