fix UI-select-extended searchable issues #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kajambiya was the intention of the video on the description meant to show the searchable demo? |
It was to show that the searchable Ui-Select-Extended control picks a value in edit mode. |
pirupius
reviewed
Feb 2, 2024
Comment on lines
33
to
34
| const [savedSearchableItemDisplay, setSavedSearchableItemDisplay] = useState(''); | ||
| const [savedSearchableItem, setSavedSearchableItem] = useState({}); |
There was a problem hiding this comment.
These 2 states might become confusing. Isn't savedSearchableItemDisplay derived from savedSearchableItem?
There was a problem hiding this comment.
Nice catch. Fixed
Comment on lines
73
to
74
| setSavedSearchableItem(dataItem); | ||
| setSavedSearchableItemDisplay(dataItem.display); |
There was a problem hiding this comment.
Is there a reason why these 2 are separated? it looks like duplication
pirupius
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
The UI-select-extended control has 2 flavours:
Preloaded(default): Where the data source is loaded on page load and you just search through the items.Searchable: Data source is not pre loaded but as you type, a request is made to the endpoint to return results matching the search criteria.There were bugs for the
searchableflavours, i.e in edit mode, it would not pick the saved value. Also in enter mode, it would not show the option for reusing previous value.This PR seeks to resolve the issues above
Screenshots
Screen.Recording.2024-02-01.at.13.57.52.mov
Related Issue
Other