Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Remove millis prop from Toast component #172

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Feb 24, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Following openmrs/openmrs-esm-core#937, the Toast notification component no longer accepts a millis prop. This PR removes the prop from an invocation of showToast in the form engine.

Screenshots

Related Issue

Other

  • Per our design guidelines, error snackbars are probably a better fit for this use case in error-utils.ts. Toasts are meant to be used for system-generated notifications that are not a result of user action.
  • This change was occasioned by CI failures upstream in the Patient Chart owing to failed TypeScript checks after updating to the latest version of the framework.

Copy link

Size Change: -12 B (0%)

Total Size: 1.05 MB

ℹ️ View Unchanged
Filename Size Change
dist/125.js 89.8 kB 0 B
dist/225.js 9.82 kB 0 B
dist/272.js 6.59 kB 0 B
dist/294.js 2.63 kB 0 B
dist/340.js 189 kB 0 B
dist/366.js 6.94 kB 0 B
dist/612.js 6.59 kB 0 B
dist/693.js 1.58 kB 0 B
dist/709.js 2.42 kB 0 B
dist/787.js 822 B 0 B
dist/800.js 175 kB 0 B
dist/986.js 237 kB -12 B (0%)
dist/main.js 317 kB 0 B
dist/openmrs-form-engine-lib.js 3.22 kB 0 B

compressed-size-action

Copy link
Contributor

@arodidev arodidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arodidev arodidev merged commit a444971 into main Feb 24, 2024
5 checks passed
@arodidev arodidev deleted the feat/toast-props branch February 24, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants