-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
O3-3006 (feat) Introduce Encounter Provider Control #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to see this taking shape, just a few early comments
src/components/inputs/ui-select-extended/ui-select-extended.tsx
Outdated
Show resolved
Hide resolved
3e30d5f
to
12e325d
Compare
Very timely, thanks! |
12e325d
to
0b4843d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm starting to believe that we need to rethink the forms registry implementation. We could consider powering the registry with an IoC container like inversify. Otherwise thanks for the great work @kajambiya, below are my final comments.
c082bba
to
15578b7
Compare
Hi @samuelmale |
…ter location and encounter datetime. Perform code clean ups
15578b7
to
3d290ad
Compare
Thank you @samuelmale for you valuable comments on this PR and @kajambiya for your hard work and persistence |
Requirements
Summary
This PR introduces the Encounter Provider control.
When submitting an encounter, RFE by default picks the provider from the session(logged in user) however there are scenario where the provider is passed as part of the encounter. In this case, the default provider needs to be overridden.
The PR also introduces logic to load default values for
encounter-provider
,encounter-location
andencounter-datetime
Screenshots
Screen.Recording.2024-03-12.at.09.19.59.mov
Screen.Recording.2024-04-02.at.21.32.48.mov
Related Issue
Other