Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Separate linting and formatting concerns #178

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

denniskigen
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Our current setup is running Prettier as a part of ESLint. These are two separate concerns that should be handled separately by different tools.

This PR removes eslint-plugin-prettier and eslint-config-prettier from our linting config as recommended here and here. I've also separated ESLint concerns from Prettier so that ESLint doesn't handle both. The recommended modern approach treats Prettier and ESLint as separate unrelated tools.

I've also moved the prettier script from the root-level package.json to the lint-staged config so that lint-staged runs Prettier after ESLint.

Additionally, I've bumped yarn to the latest stable version.

Screenshots

Related Issue

Other

@denniskigen denniskigen requested a review from ibacher April 5, 2024 19:45
Copy link

github-actions bot commented Apr 5, 2024

Size Change: +4 B (0%)

Total Size: 1.05 MB

ℹ️ View Unchanged
Filename Size Change
dist/125.js 89.8 kB 0 B
dist/225.js 9.82 kB 0 B
dist/272.js 6.59 kB 0 B
dist/294.js 2.63 kB 0 B
dist/340.js 189 kB 0 B
dist/366.js 6.94 kB 0 B
dist/612.js 6.59 kB 0 B
dist/693.js 1.58 kB 0 B
dist/709.js 2.42 kB 0 B
dist/771.js 236 kB +4 B (0%)
dist/787.js 822 B 0 B
dist/800.js 175 kB 0 B
dist/main.js 315 kB 0 B
dist/openmrs-form-engine-lib.js 3.22 kB 0 B

compressed-size-action

@denniskigen denniskigen force-pushed the chore/tooling branch 2 times, most recently from a614478 to 76202a7 Compare April 5, 2024 20:00
Copy link
Member

@samuelmale samuelmale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @denniskigen!

@samuelmale samuelmale merged commit 5969c51 into main Apr 8, 2024
5 checks passed
@samuelmale samuelmale deleted the chore/tooling branch April 8, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants