(chore) Separate linting and formatting concerns #178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Our current setup is running Prettier as a part of ESLint. These are two separate concerns that should be handled separately by different tools.
This PR removes eslint-plugin-prettier and eslint-config-prettier from our linting config as recommended here and here. I've also separated ESLint concerns from Prettier so that ESLint doesn't handle both. The recommended modern approach treats Prettier and ESLint as separate unrelated tools.
I've also moved the
prettier
script from the root-levelpackage.json
to thelint-staged
config so thatlint-staged
runs Prettier after ESLint.Additionally, I've bumped yarn to the latest stable version.
Screenshots
Related Issue
Other