Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Ensure forms loader maintains immutability of the schema input #188

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

samuelmale
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Changes in this PR fix an issue in the form-builder where the form-schema transformer was overriding the Json Schema on saving the form. This has been fixed by a deep clone of the schema to avoid referencing the same object address in memory. Further more, I've also made sure the schema transformers run post subforms resolution.

Screenshots

N/A

Related Issue

N/A

Other

N/A

@samuelmale samuelmale requested review from donaldkibet and kajambiya and removed request for donaldkibet April 16, 2024 15:54
Copy link

Size Change: -237 kB (-18%) 👏

Total Size: 1.05 MB

Filename Size Change
dist/417.js 0 B -237 kB (removed) 🏆
ℹ️ View Unchanged
Filename Size Change
dist/121.js 237 kB 0 B
dist/184.js 203 kB 0 B
dist/207.js 6.07 kB 0 B
dist/225.js 9.82 kB 0 B
dist/272.js 6.59 kB 0 B
dist/294.js 2.63 kB 0 B
dist/366.js 6.94 kB 0 B
dist/693.js 1.58 kB 0 B
dist/709.js 2.42 kB 0 B
dist/787.js 822 B 0 B
dist/800.js 169 kB 0 B
dist/9.js 90.2 kB 0 B
dist/main.js 315 kB -5 B (0%)
dist/openmrs-form-engine-lib.js 3.39 kB -3 B (0%)

compressed-size-action

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick turnaround, @samuelmale

@donaldkibet donaldkibet merged commit 7ebbf99 into main Apr 17, 2024
5 checks passed
@donaldkibet donaldkibet deleted the fix/forms-loader-immutability branch April 17, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants