Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

03-2167:Support associating concept representation with questions #189

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

gitcliff
Copy link
Contributor

@gitcliff gitcliff commented Apr 17, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

PR Adds the concept object within the data structure (possible in a new "meta" property, so that we dont need to make subsequent backend calls to get more information about the concept associated with the question

Screenshots

Screenshot 2024-04-16 at 10 40 17 PM

Related Issue

Other

Copy link
Member

@samuelmale samuelmale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitcliff can you also remove functions like: getConceptNameAndUUID and probably fetchConceptNameByUuid?

src/components/encounter/ohri-encounter-form.component.tsx Outdated Show resolved Hide resolved
src/components/inputs/date/ohri-date.component.tsx Outdated Show resolved Hide resolved
@samuelmale samuelmale merged commit ddf7a18 into openmrs:main Apr 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants