(fix) O3-2154: Selecting a date should set selected date's time to midnight in the local timezone #197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR looks into the following issues:
When a user selects a date, the date's equivalent in UTC is calculated and saved in the form. For the Timezones behind the UTC, when the user selects a date, the date's time is sent as
00:00:00
by the Date picker. Setting the date in the negative offset timezone would set the selected date as the previous one.All the dates should be handled in local time zones
Screenshots
For Pacific time zone
After
Screen.Recording.2024-04-22.at.06.05.21.mov
Related Issue
https://issues.openmrs.org/browse/O3-2154
Other
Also, the tests are updated such that they should work in all timezones