Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(test) Fix warnings raised when running tests #204

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

denniskigen
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR fixes various issues that result in warnings when running tests. These include:

  • Invalid prop types for Carbon components
  • Missing or non-unique keys for children

Screenshots

Related Issue

Other

Copy link

github-actions bot commented Apr 23, 2024

Size Change: +356 B (0%)

Total Size: 1.06 MB

ℹ️ View Unchanged
Filename Size Change
dist/100.js 2.41 kB 0 B
dist/225.js 2.57 kB 0 B
dist/29.js 169 kB 0 B
dist/327.js 1.58 kB 0 B
dist/353.js 3.02 kB 0 B
dist/373.js 237 kB +196 B (0%)
dist/459.js 6.07 kB 0 B
dist/505.js 6.95 kB 0 B
dist/540.js 2.63 kB 0 B
dist/606.js 2.23 kB 0 B
dist/616.js 202 kB 0 B
dist/791.js 9.8 kB 0 B
dist/859.js 830 B 0 B
dist/886.js 6.59 kB 0 B
dist/942.js 482 B 0 B
dist/981.js 85.7 kB 0 B
dist/993.js 3.08 kB 0 B
dist/main.js 311 kB +160 B (0%)
dist/openmrs-form-engine-lib.js 3.58 kB 0 B

compressed-size-action

@denniskigen denniskigen marked this pull request as ready for review April 23, 2024 05:31
@samuelmale
Copy link
Member

@denniskigen can we have the conflicts fixed?

@denniskigen
Copy link
Member Author

Done. Fixed in the latest push.

Copy link
Member

@samuelmale samuelmale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @denniskigen for your infinite brushes 🎉

@samuelmale samuelmale merged commit c6405c8 into main Apr 23, 2024
5 checks passed
@samuelmale samuelmale deleted the test/fix-warnings branch April 23, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants