(test) Refactor tests for the Form component #207
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR refactors tests for the Form component with the primary goal of reducing reliance on async behaviour and the use of asynchronous matchers. Consequently, the test suite should be easier to read and reason about. In most cases, rendering the component, allowing some time for the asynchronous behaviour to occur, and then checking for the disappearance of the loading spinner should be enough to allow asynchronous operations to complete.
In the few cases where the delay is insufficient and more time is required for async operations to complete, I've queued up the render using:
Screenshots
Related Issue
Other