Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-2050 prevent number input change on mouse/touchpad scroll #21

Merged

Conversation

pirupius
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Number input values have been incrementing and decrementing when in focus and a mouse is scrolled.

Screenshots

Screen.Recording.2023-04-17.at.15.53.59.mov

Related Issue

Other

@github-actions
Copy link

Size Change: +16 B (0%)

Total Size: 734 kB

ℹ️ View Unchanged
Filename Size Change
dist/225.js 9.82 kB 0 B
dist/272.js 6.59 kB 0 B
dist/294.js 2.63 kB 0 B
dist/366.js 6.94 kB 0 B
dist/472.js 34.4 kB +16 B (0%)
dist/591.js 2.96 kB 0 B
dist/595.js 106 kB 0 B
dist/634.js 777 B 0 B
dist/709.js 2.42 kB 0 B
dist/852.js 174 kB 0 B
dist/986.js 193 kB 0 B
dist/main.js 192 kB 0 B
dist/openmrs-form-engine-lib.js 3.25 kB 0 B

compressed-size-action

@denniskigen
Copy link
Member

LGTM. Any idea why disableWheel doesn't work here?

@samuelmale samuelmale merged commit 9461efd into main Apr 18, 2023
@samuelmale samuelmale deleted the O3-2050/prevent-number-input-change-on-mouse-scroll branch April 18, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants