Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Flag required fields upon form submission #212

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Apr 24, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR fixes the styling of required fields so that they get flagged better when a form is submitted without filling mandatory fields.

Screenshots

flag-mandatory-fields.mp4

Related Issue

Other

Copy link

github-actions bot commented Apr 24, 2024

Size Change: +80 B (0%)

Total Size: 1.22 MB

ℹ️ View Unchanged
Filename Size Change
dist/100.js 2.41 kB 0 B
dist/154.js 80.8 kB 0 B
dist/17.js 16.4 kB 0 B
dist/225.js 2.57 kB 0 B
dist/248.js 108 kB 0 B
dist/29.js 220 kB 0 B
dist/327.js 1.58 kB 0 B
dist/353.js 3.02 kB 0 B
dist/459.js 6.07 kB 0 B
dist/505.js 7.46 kB 0 B
dist/540.js 2.63 kB 0 B
dist/561.js 487 B 0 B
dist/599.js 2.5 kB 0 B
dist/606.js 2.23 kB 0 B
dist/633.js 95 kB 0 B
dist/784.js 237 kB -49 B (0%)
dist/791.js 9.8 kB 0 B
dist/828.js 94 kB 0 B
dist/859.js 879 B 0 B
dist/886.js 6.94 kB 0 B
dist/942.js 487 B 0 B
dist/993.js 3.08 kB 0 B
dist/main.js 312 kB +129 B (0%)
dist/openmrs-form-engine-lib.js 3.77 kB 0 B

compressed-size-action

Copy link
Member

@samuelmale samuelmale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelmale samuelmale merged commit 6c33bf8 into main Apr 24, 2024
5 checks passed
@samuelmale samuelmale deleted the fix/flag-required-fields branch April 24, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants