Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) O3-3099: Render labels instead of UUIDs for multiCheckbox field answers #213

Merged
merged 1 commit into from
Apr 24, 2024
Merged

(feat) O3-3099: Render labels instead of UUIDs for multiCheckbox field answers #213

merged 1 commit into from
Apr 24, 2024

Conversation

gitcliff
Copy link
Contributor

@gitcliff gitcliff commented Apr 24, 2024 •
edited by denniskigen
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

The React Form Engine fails to accurately translate UUIDs into their corresponding selected answers for multi-select responses. While in multi-select responses with the Angular Form Engine, selected answers typically display in the box as expected, the React Form Engine presents the UUID rather than the selected answer.

Screenshots

Screenshot 2024-04-24 at 3 02 28 PM

Related Issue

https://openmrs.atlassian.net/browse/O3-3099

Other

@gitcliff gitcliff changed the title 03-3099:Multi-select responses display UUIDs instead of the actual se… (feat) 03-3099 Multi-select responses display UUIDs instead of the actual se… Apr 24, 2024
@gitcliff gitcliff changed the title (feat) 03-3099 Multi-select responses display UUIDs instead of the actual se… (feat) 03-3099 Selected answers in the multi-select question should display labels instead of UUIDs Apr 24, 2024
@gitcliff gitcliff changed the title (feat) 03-3099 Selected answers in the multi-select question should display labels instead of UUIDs (feat) 03-3099 Selected answers for questions with checkbox rendering should display labels instead of UUIDs Apr 24, 2024
@gitcliff
Copy link
Contributor Author

helo @denniskigen ,, requesting for review
Thanks

@denniskigen denniskigen changed the title (feat) 03-3099 Selected answers for questions with checkbox rendering should display labels instead of UUIDs (feat) O3-3099: Render labels instead of UUIDs for multiCheckbox field answers Apr 24, 2024
@denniskigen
Copy link
Member

Hi @gitcliff, I've taken the liberty to tweak the approach so that the labels display as Tags:

CleanShot 2024-04-24 at 11  56 06@2x

@denniskigen denniskigen merged commit 31d43d4 into openmrs:main Apr 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen denniskigen approved these changes

@samuelmale samuelmale Awaiting requested review from samuelmale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitcliff @denniskigen