(feat) Setup i18n for form engine lib #215
Conversation
vasharma05
force-pushed
the
feat/form-engine-translations
branch
from
271041b
to
e2f7ab8
Compare
vasharma05
force-pushed
the
feat/form-engine-translations
branch
2 times, most recently
from
3f0d89f
to
0c249a7
Compare
|
Size Change: -332 kB (-21%) 🎉 Total Size: 1.22 MB
ℹ️ View Unchanged
|
src/i18n.ts
Outdated
| @@ -0,0 +1,23 @@ | |||
| function loadResourcesFromFile() { | |||
| const lang = window.i18next.language; | |||
There was a problem hiding this comment.
Rather than directly referencing window.i18next, I'd mark i18next as a peer dependency and import it in this file.
There was a problem hiding this comment.
Getting undefined with i18next reference. Do you know what might be the reason?
There was a problem hiding this comment.
When in the app is that happening? It's vaguely possible that language is undefined, but window.i18next should be set here. That's called after apps are registered, but it should be before anything gets mounted (since single-spa isn't called until setupI18n() succeeds).
|
window.18next.on is breaking the tests. Do we have a mock for it somewhere you're aware of, @ibacher? |
|
|
|
Hi @ibacher! 
|
src/withFormEngineTranslations.tsx
Outdated
| export default function withFormEngineTranslations(WrappedComponent: React.ComponentType<any>) { | ||
| return function WithTranslation(props: any) { | ||
| return ( | ||
| <I18nextProvider i18n={window.i18next} defaultNS="@openmrs/openmrs-form-engine-lib"> | ||
| <WrappedComponent {...props} /> | ||
| </I18nextProvider> | ||
| ); | ||
| }; | ||
| } |
There was a problem hiding this comment.
@vasharma05 There's a bunch of type errors in this file
There was a problem hiding this comment.
Should be resolved now, add the mock for I18nextProvider
vasharma05
force-pushed
the
feat/form-engine-translations
branch
from
bc5c95e
to
709eca1
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Requirements
Summary
This PR implements internationalization in the Form Engine Library. Whenever the form engine lib is loaded, the lib will look for the active locale via the
window.i18next.languageand then load the particular file from the translation folder into the i18next instance. The same instance is then shared with the OHRIForm using theI18NextProvidervia a HOCwithTranslation.Please note that in case the language is loaded, the corresponding translation resource will be loaded into the i18next in the runtime.
Screenshots
Related Issue
TBD
Other