O3-2057 Add support to display error messages on Number input control #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmale
requested changes
Apr 18, 2023
Comment on lines
428
to
443
| if (field.questionOptions.rendering == 'number') { | ||
| let min = field.questionOptions.min; | ||
| let max = field.questionOptions.max; | ||
| if (min && Number(value) < Number(min)) { | ||
| errors.push({ | ||
| resultType: 'error', | ||
| message: `Field value can't be less than ${min}`, | ||
| }); | ||
| if (max && Number(value) > Number(max)) { | ||
| errors.push({ | ||
| resultType: 'error', | ||
| message: `Field value can't be greater than ${max}`, | ||
| }); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Move this to the default validator
samuelmale
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where there's an error on the number field and field is highlighted in red but no error message is displayed.