Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Show asterisks next to labels for required fields #222

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

denniskigen
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR adds a red asterisk to form labels for required fields as shown below:

Screenshots

required-asterisk.mp4

Related Issue

Other

Copy link

github-actions bot commented Apr 25, 2024

Size Change: -239 kB (-17%) 👏

Total Size: 1.13 MB

Filename Size Change
dist/224.js 0 B -239 kB (removed) 🏆
ℹ️ View Unchanged
Filename Size Change
dist/17.js 16.6 kB 0 B
dist/184.js 11.2 kB 0 B
dist/225.js 2.57 kB 0 B
dist/29.js 206 kB 0 B
dist/300.js 592 B 0 B
dist/327.js 1.59 kB 0 B
dist/335.js 958 B 0 B
dist/353.js 3.02 kB 0 B
dist/439.js 6.24 kB 0 B
dist/505.js 7.46 kB 0 B
dist/540.js 2.63 kB 0 B
dist/55.js 752 B 0 B
dist/569.js 2.5 kB 0 B
dist/581.js 203 kB 0 B
dist/606.js 2.23 kB 0 B
dist/635.js 14.2 kB 0 B
dist/713.js 239 kB 0 B
dist/767.js 79.1 kB 0 B
dist/886.js 6.94 kB 0 B
dist/942.js 482 B 0 B
dist/99.js 692 B 0 B
dist/993.js 3.08 kB 0 B
dist/main.js 312 kB +226 B (0%)
dist/openmrs-form-engine-lib.js 3.78 kB -2 B (0%)

compressed-size-action

@denniskigen denniskigen force-pushed the feat/required-field-asterisks branch 2 times, most recently from 7211e46 to efde6eb Compare April 25, 2024 11:03
@denniskigen denniskigen force-pushed the feat/required-field-asterisks branch from efde6eb to b1f7adb Compare April 25, 2024 11:13
src/form-engine.test.tsx Outdated Show resolved Hide resolved
Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just the commented code

src/form-engine.test.tsx Outdated Show resolved Hide resolved
@denniskigen denniskigen force-pushed the feat/required-field-asterisks branch from b1f7adb to 62f86d7 Compare April 25, 2024 12:04
@denniskigen denniskigen merged commit 08745e9 into main Apr 25, 2024
4 checks passed
@denniskigen denniskigen deleted the feat/required-field-asterisks branch April 25, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants