Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Improvements following code refactor/rename #224

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

pirupius
Copy link
Member

@pirupius pirupius commented Apr 25, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

  • Renames fetchClobdata to fetchClobData
  • Renames carbon ContentSwitcher alias
  • Adds useMemo to multiselect to improve performance
  • Renames UISelectExtended to UiSelectExtended
  • Improve typings
  • Delete and refactor unnecessary tags
  • Moved @carbon/react from peer to dependency

Screenshots

Related Issue

Other

Copy link

github-actions bot commented Apr 25, 2024

Size Change: -162 kB (-12%) 👏

Total Size: 1.2 MB

Filename Size Change
dist/581.js 0 B -203 kB (removed) 🏆
dist/767.js 0 B -79.1 kB (removed) 🏆
dist/main.js 442 kB +131 kB (+42%) 🚨
ℹ️ View Unchanged
Filename Size Change
dist/17.js 16.5 kB -7 B (0%)
dist/184.js 11.2 kB 0 B
dist/225.js 2.57 kB 0 B
dist/29.js 206 kB 0 B
dist/300.js 592 B 0 B
dist/327.js 1.59 kB 0 B
dist/335.js 958 B 0 B
dist/353.js 3.02 kB 0 B
dist/439.js 0 B -6.24 kB (removed) 🏆
dist/5.js 79.5 kB 0 B
dist/505.js 6.94 kB -519 B (-7%)
dist/509.js 2.92 kB 0 B
dist/540.js 2.63 kB 0 B
dist/55.js 752 B 0 B
dist/569.js 0 B -2.5 kB (removed) 🏆
dist/606.js 2.23 kB 0 B
dist/635.js 14.2 kB 0 B
dist/713.js 239 kB -21 B (0%)
dist/738.js 150 kB 0 B
dist/886.js 6.89 kB -46 B (-1%)
dist/942.js 0 B -482 B (removed) 🏆
dist/99.js 692 B 0 B
dist/993.js 3.08 kB 0 B
dist/openmrs-form-engine-lib.js 3.73 kB -54 B (-1%)

compressed-size-action

@denniskigen denniskigen merged commit 302dc77 into main Apr 25, 2024
4 checks passed
@denniskigen denniskigen deleted the fix/refactor-improvements branch April 25, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants