Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor) Use one component export syntax for consistency #243

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

denniskigen
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

We currently use a mix of named and default exports for components. This PR switches to using default exports for components with a single export, similar to what we do in other repositories. This makes things more consistent.

Screenshots

Related Issue

Other

Copy link

github-actions bot commented Apr 29, 2024

Size Change: -2.81 kB (0%)

Total Size: 1.13 MB

ℹ️ View Unchanged
Filename Size Change
dist/17.js 16.6 kB 0 B
dist/184.js 11.2 kB 0 B
dist/225.js 2.57 kB 0 B
dist/29.js 206 kB 0 B
dist/300.js 592 B 0 B
dist/327.js 1.59 kB 0 B
dist/335.js 958 B 0 B
dist/353.js 3.02 kB 0 B
dist/41.js 3.36 kB 0 B
dist/422.js 3.03 kB 0 B
dist/439.js 6.24 kB 0 B
dist/499.js 2.5 kB 0 B
dist/505.js 7.46 kB 0 B
dist/522.js 240 kB -51 B (0%)
dist/540.js 2.63 kB 0 B
dist/55.js 752 B 0 B
dist/569.js 0 B -2.5 kB (removed) 🏆
dist/581.js 203 kB 0 B
dist/606.js 2.23 kB 0 B
dist/635.js 14.2 kB 0 B
dist/767.js 79.1 kB 0 B
dist/886.js 6.94 kB 0 B
dist/942.js 482 B 0 B
dist/99.js 692 B 0 B
dist/993.js 3.08 kB 0 B
dist/main.js 311 kB -255 B (0%)
dist/openmrs-form-engine-lib.js 3.81 kB 0 B

compressed-size-action

Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @denniskigen

@pirupius pirupius merged commit 8e5b45a into main Apr 29, 2024
4 checks passed
@pirupius pirupius deleted the refactor/default-exports branch April 29, 2024 15:10
usamaidrsk pushed a commit to usamaidrsk/openmrs-form-engine-lib that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants